Remove redundant COUNT() call for 1st page of results #34484

lbajsarowicz · 2021-10-29T22:20:20Z

Description (*)

Magento is performing lots of redundant DB calls in all the places where pagination is used.

The Category Edit page is one of the examples. If you are on the 1st page, it does not make sense to calculate the last page and redirect to the 1st one... Because you are on the 1st one.

The results of this optimization are worth the change :)

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-10-29T22:20:23Z

Hi @lbajsarowicz. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

lbajsarowicz · 2021-10-29T22:52:40Z

@magento run all tests

magento-automated-testing · 2021-10-29T22:52:47Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev

Hi @lbajsarowicz,
Great improvement! I guess for large data sets it might be really noticeable. Do you have some measurements?
PS: I guess you're talking about the grid of the products that are used in the category, right?

Could you cover this change with a simple unit test?

lbajsarowicz · 2021-10-30T09:26:37Z

@ihor-sviziev Of course, Unit Tests are coming in another commit.

@OlgaVasyltsun Quick hint for you: When you are creating a new plugin, like \Magento\Theme\Plugin\Data\Collection:

It's more helpful when you are navigating through the plugins when name of a plugin contains Plugin suffix
I strongly recommend naming the plugins by their role, not the class they override. Why? It's simple:
- It helps to keep Single Responsibility in the class, as lazy developers won't add other logic into the same plugin,
- A single plugin can be applied to different classes, based on the Interface passed in $subject.

Of course, these are only hints.

lbajsarowicz · 2021-10-30T09:44:31Z

@magento run unit tests

magento-automated-testing · 2021-10-30T09:44:39Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-10-30T12:10:01Z

@magento run all tests

magento-automated-testing · 2021-10-30T12:10:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-10-30T15:23:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-11-01T20:48:24Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-11-02T13:18:43Z

@magento run Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2021-11-02T13:18:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-11-02T20:04:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-11-03T08:06:44Z

@magento run Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2021-11-03T08:06:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-11-03T11:38:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-11-04T07:41:17Z

@magento convert to patch for 2.4.3

ihor-sviziev · 2021-11-04T07:41:24Z

@magento convert to patch for 2.3.7

m2-github-services · 2021-11-04T07:42:12Z

@ihor-sviziev changes has been successfully converted for 2.4.3 version and pushed to the converted-magento-magento2-2.4.3 branch.

You may submit a pull request using the link: 2.4.3-release...magento:converted-magento-magento2-2.4.3

ihor-sviziev · 2021-11-04T07:45:45Z

Hi @lbajsarowicz,
Could you create a new PR (in addition to this) for the following changes 2.4.3-release...magento:converted-magento-magento2-2.4.3 to convert them to a quality patch?

Den4ik · 2021-11-04T13:21:47Z

@sidolov, I believe that we could move it to "Merge in Progress".

sidolov · 2021-11-04T17:17:29Z

@magento convert to patch for 2.3.7

sidolov · 2021-11-04T19:42:27Z

@magento convert to patch for 2.3.7

m2-github-services · 2021-11-04T19:43:01Z

@sidolov an error occurred during the patch generation.
Failure can be caused by the incompatible with base branch changes.
To replicate the issue try to apply patch locally using git am command.

ihor-sviziev · 2021-11-08T12:18:12Z

@magento convert to patch for 2.4.3

m2-github-services · 2021-11-08T12:19:00Z

@ihor-sviziev changes has been successfully converted for 2.4.3 version and pushed to the converted-magento-magento2-34484-2.4.3 branch.

You may submit a pull request using the link: 2.4.3-release...magento:converted-magento-magento2-34484-2.4.3

Remove redundant COUNT() call for 1st page of results

a08d497

magento-engcom-team added Component: Theme Release Line: 2.4 Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner labels Oct 29, 2021

m2-community-project bot added the Progress: pending review label Oct 29, 2021

nrkapoor requested review from kandy, ddzhura and vzabaznov October 29, 2021 22:58

ihor-sviziev self-assigned this Oct 30, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Oct 30, 2021

ihor-sviziev added Area: Performance Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Oct 30, 2021

ihor-sviziev requested changes Oct 30, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Oct 30, 2021

ihor-sviziev added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Risk: low labels Oct 30, 2021

Cover change with Unit Tests

8d75952

Den4ik self-requested a review October 30, 2021 11:33

nrkapoor added this to the 2.4.4 milestone Nov 2, 2021

nrkapoor added Severity: S1 Affects critical data or functionality and forces users to employ a workaround. and removed Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 2, 2021

sidolov added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Nov 3, 2021

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Nov 4, 2021

kandy removed their assignment Nov 4, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: accept labels Nov 4, 2021

magento deleted a comment from m2-github-services Nov 4, 2021

magento-engcom-team merged commit 4bf488d into magento:2.4-develop Dec 9, 2021

Remove redundant COUNT() call for 1st page of results #34484

Remove redundant COUNT() call for 1st page of results #34484

Uh oh!

Conversation

lbajsarowicz commented Oct 29, 2021 • edited by mrtuvn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Oct 29, 2021

Uh oh!

lbajsarowicz commented Oct 29, 2021

Uh oh!

magento-automated-testing bot commented Oct 29, 2021

Uh oh!

ihor-sviziev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lbajsarowicz commented Oct 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lbajsarowicz commented Oct 30, 2021

Uh oh!

magento-automated-testing bot commented Oct 30, 2021

Uh oh!

ihor-sviziev commented Oct 30, 2021

Uh oh!

magento-automated-testing bot commented Oct 30, 2021

Uh oh!

magento-automated-testing bot commented Oct 30, 2021

Uh oh!

magento-automated-testing bot commented Nov 1, 2021

Uh oh!

ihor-sviziev commented Nov 2, 2021

Uh oh!

magento-automated-testing bot commented Nov 2, 2021

Uh oh!

magento-automated-testing bot commented Nov 2, 2021

Uh oh!

ihor-sviziev commented Nov 3, 2021

Uh oh!

magento-automated-testing bot commented Nov 3, 2021

Uh oh!

magento-automated-testing bot commented Nov 3, 2021

Uh oh!

ihor-sviziev commented Nov 4, 2021

Uh oh!

ihor-sviziev commented Nov 4, 2021

Uh oh!

m2-github-services commented Nov 4, 2021

Uh oh!

ihor-sviziev commented Nov 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Den4ik commented Nov 4, 2021

Uh oh!

sidolov commented Nov 4, 2021

Uh oh!

sidolov commented Nov 4, 2021

Uh oh!

m2-github-services commented Nov 4, 2021

Uh oh!

ihor-sviziev commented Nov 8, 2021

Uh oh!

m2-github-services commented Nov 8, 2021

Uh oh!

Uh oh!

lbajsarowicz commented Oct 29, 2021 •

edited by mrtuvn

Loading

ihor-sviziev left a comment •

edited

Loading

lbajsarowicz commented Oct 30, 2021 •

edited

Loading

ihor-sviziev commented Nov 4, 2021 •

edited

Loading