Add loading lazy for also for ko templates #34558

in-session · 2021-11-07T09:13:51Z

Description (*)

Add lazy loading images on supported browsers for ko templates minicart/order summary and admin products grid

m2-assistant · 2021-11-07T09:13:54Z

Hi @in-session. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

in-session · 2021-11-07T10:12:59Z

@magento run all tests

magento-automated-testing · 2021-11-07T10:13:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

in-session · 2021-11-07T21:24:26Z

@magento run Semantic Version Checker, Functional Tests EE, Functional Tests CE, Unit Tests

magento-automated-testing · 2021-11-07T21:24:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-11-08T08:16:54Z

@magento create issue
@sidolov I set priority to P2 as this change improves performance by lazy loading images on supported browsers

ihor-sviziev

✔ Approved.

Failing tests look not related to changes from this PR.

magento-engcom-team · 2021-11-08T08:18:30Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9333 has been created to process this Pull Request

magento-engcom-team · 2021-11-08T09:45:30Z

Hi @Den4ik, thank you for the review.
ENGCOM-9333 has been created to process this Pull Request

ihor-sviziev · 2021-11-09T10:06:39Z

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE, Unit Tests

magento-automated-testing · 2021-11-09T10:06:43Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-12-08T09:48:34Z

Hi @Den4ik, thank you for the review.
ENGCOM-9333 has been created to process this Pull Request

engcom-Alfa · 2021-12-08T10:05:58Z

@magento run Functional Tests EE

magento-automated-testing · 2021-12-08T10:06:05Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Alfa · 2021-12-08T12:14:37Z

@magento run Functional Tests EE

magento-automated-testing · 2021-12-08T12:14:45Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Alfa

✔️ QA Passed

Preconditions:

Should have Magento latest clean instance installed with Sample data

Manual testing scenario:

Navigate to Admin > Catalog > Products
Select the 200 products to be displayed per page instead of default value 20
Inspect the element network tab with img section filtered with searched label product.
Refresh the page and check the logged image requests
After loading the page, start scrolling down the grid and check more image requests are being processed

Before: ✖️ All 200 images used to be requested in the first page load request only

After: ✔️ Only limited image requests are being made, further images are getting requested however the grid scrolls down further.

There is no further testing is required on this or additional regression is required since it is just a part of lazy loading issue!

engcom-Alfa · 2021-12-08T15:39:40Z

There is an auto-test failing @magento run Functional Tests EE and so moving it to Extended testing, else bot keeps automatically moving it back to Ready For Testing!

magento-automated-testing · 2021-12-08T18:24:24Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-12-09T06:25:21Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

in-session · 2021-12-10T16:03:12Z

@magento run Functional Tests EE

magento-automated-testing · 2021-12-10T16:03:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-12-11T05:59:57Z

@engcom-Alfa, the tests are passing, so I'm moving it to ready for merge

ishakhsuvarov · 2022-06-13T15:37:42Z

@magento run all tests

magento-automated-testing · 2022-06-13T15:37:47Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ishakhsuvarov · 2022-06-13T18:38:09Z

@magento run Functional Tests EE

magento-automated-testing · 2022-06-13T18:38:17Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

in-session added 4 commits November 7, 2021 09:59

Update image_with_borders.html

4c503ad

Update image_with_borders.html

3537880

Update image.html

3115e80

Update image.html

c709a8c

magento-engcom-team added Area: Frontend Component: Catalog Release Line: 2.4 labels Nov 7, 2021

m2-community-project bot added the Progress: pending review label Nov 8, 2021

m2-assistant bot mentioned this pull request Nov 8, 2021

[Issue] Add loading lazy for also for ko templates #34563

Closed

5 tasks

ihor-sviziev approved these changes Nov 8, 2021

View reviewed changes

m2-community-project bot assigned ihor-sviziev Nov 8, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels Nov 8, 2021

Den4ik approved these changes Nov 8, 2021

View reviewed changes

m2-community-project bot assigned Den4ik Nov 8, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Dec 8, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 8, 2021

engcom-Alfa approved these changes Dec 8, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing Progress: testing in progress and removed Progress: testing in progress Progress: ready for testing labels Dec 8, 2021

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Dec 8, 2021

ihor-sviziev added the Progress: accept label Dec 11, 2021

m2-community-project bot removed the Progress: extended testing label Dec 11, 2021

Merge branch '2.4-develop' into patch-8

c08e3f9

magento-devops-reposync-svc merged commit ee7a4bb into magento:2.4-develop Jun 14, 2022

Add loading lazy for also for ko templates #34558

Add loading lazy for also for ko templates #34558

Uh oh!

Conversation

in-session commented Nov 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Uh oh!

m2-assistant bot commented Nov 7, 2021

Uh oh!

in-session commented Nov 7, 2021

Uh oh!

magento-automated-testing bot commented Nov 7, 2021

Uh oh!

in-session commented Nov 7, 2021

Uh oh!

magento-automated-testing bot commented Nov 7, 2021

Uh oh!

ihor-sviziev commented Nov 8, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Nov 8, 2021

Uh oh!

magento-engcom-team commented Nov 8, 2021

Uh oh!

ihor-sviziev commented Nov 9, 2021

Uh oh!

magento-automated-testing bot commented Nov 9, 2021

Uh oh!

magento-engcom-team commented Dec 8, 2021

Uh oh!

engcom-Alfa commented Dec 8, 2021

Uh oh!

magento-automated-testing bot commented Dec 8, 2021

Uh oh!

engcom-Alfa commented Dec 8, 2021

Uh oh!

magento-automated-testing bot commented Dec 8, 2021

Uh oh!

engcom-Alfa left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Alfa commented Dec 8, 2021

Uh oh!

magento-automated-testing bot commented Dec 8, 2021

Uh oh!

magento-automated-testing bot commented Dec 9, 2021

Uh oh!

in-session commented Dec 10, 2021

Uh oh!

magento-automated-testing bot commented Dec 10, 2021

Uh oh!

ihor-sviziev commented Dec 11, 2021

Uh oh!

ishakhsuvarov commented Jun 13, 2022

Uh oh!

magento-automated-testing bot commented Jun 13, 2022

Uh oh!

ishakhsuvarov commented Jun 13, 2022

Uh oh!

magento-automated-testing bot commented Jun 13, 2022

Uh oh!

Uh oh!

in-session commented Nov 7, 2021 •

edited

Loading