Skip to content

Fixed remaining failed Integration Tests for PHP 8.1. compatibility #34617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

karyna-t
Copy link
Contributor

@karyna-t karyna-t commented Nov 11, 2021

Description (*)

Fix for tests that remain failed after main 8.1 compatibility fixes

  • dev/tests/integration/testsuite/Magento/AdvancedCheckout/Model/CartTest.php
  • dev/tests/api-functional/testsuite/Magento/Webapi/WsdlGenerationFromDataObjectTest.php

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 11, 2021

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-github-services m2-github-services added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 11, 2021
@karyna-t karyna-t force-pushed the php8.1-compatibility/fix-remaining-failed-tests branch from d21e52b to fcfca14 Compare November 11, 2021 20:25
@karyna-t karyna-t changed the base branch from 2.4-develop to platform-health November 11, 2021 20:26
@andrewbess andrewbess self-assigned this Nov 11, 2021
@andrewbess andrewbess added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: pending review Project: Platform Health and removed Progress: review labels Nov 11, 2021
@andrewbess andrewbess changed the title Fix remaining failed tests for PHP 8.1. compatibility Fixed remaining failed Integration Tests for PHP 8.1. compatibility Nov 11, 2021
@andrewbess
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Nov 11, 2021

@magento run Static Tests, Integration Tests, Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Nov 12, 2021

@magento import code to Magento-trigger/magento2ce

@m2-github-services
Copy link
Collaborator

@xmav the branch with the code is successfully imported into the Magento-trigger/magento2ce repository. Branch name: imported-karyna-tsymbal-atwix-magento2-34617.

@karyna-t karyna-t force-pushed the php8.1-compatibility/fix-remaining-failed-tests branch from fcfca14 to 4af66d3 Compare November 12, 2021 10:44
@karyna-t karyna-t changed the base branch from platform-health to 2.4-develop November 12, 2021 10:55
@andrewbess
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Nov 12, 2021

FT failure is not related to changes in this PR

@xmav
Copy link
Contributor

xmav commented Nov 12, 2021

@magento import code to Magento-trigger/magento2ce

@m2-github-services
Copy link
Collaborator

@xmav the branch with the code is successfully imported into the Magento-trigger/magento2ce repository. Branch name: imported-karyna-tsymbal-atwix-magento2-34617.

@magento-engcom-team magento-engcom-team merged commit 96cb9da into magento:2.4-develop Nov 15, 2021
@karyna-t karyna-t deleted the php8.1-compatibility/fix-remaining-failed-tests branch November 26, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogInventory Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: review Project: Platform Health Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants