-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix the newsletter confirmation email From #34635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix the newsletter confirmation email From on multi-store env
Hi @sevka. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sevka,
Thank you for your contribution!
Could you sign the Adobe CLA and cover your changes with some automated tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @sevka
Thank you for your contribution.
Could you please fix static and unit tests
Thank you in advance.
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@sevka Please sign CLA. We could not merge PR without that. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @sevka, Thank you for your contribution! We are not able to proceed further on this PR as you have not sign the Adobe CLA yet. Hence closing this PR. Please reopen and update if you wish to continue. Thank you for your contribution! |
@magento create issue |
Fix the newsletter confirmation email From on multi-store env
Description (*)
Bug: the newsletter subscription confirmation email has the wrong email in From field
if the customer is assigned to a non-default store and subscribed/unsubscribed via admin panel
Related Pull Requests
Fixed Issues (if relevant)
I didn't find the existing issue
Manual testing scenarios (*)
Expected:
The customer receives an email with a store-specific email in From header
Actual:
The customer receives an email with default email in From header
Questions or comments
Contribution checklist (*)
Resolved issues: