Skip to content

Fix the newsletter confirmation email From #34635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix the newsletter confirmation email From #34635

wants to merge 5 commits into from

Conversation

sevka
Copy link

@sevka sevka commented Nov 15, 2021

Fix the newsletter confirmation email From on multi-store env

Description (*)

Bug: the newsletter subscription confirmation email has the wrong email in From field
if the customer is assigned to a non-default store and subscribed/unsubscribed via admin panel

Related Pull Requests

Fixed Issues (if relevant)

I didn't find the existing issue

Manual testing scenarios (*)

  1. In admin panel of multi-store Magento, open some customer that assigned to non-default store
  2. Go to "Newsletter" tab
  3. Select (or unelect if it's selected already) the "Subscribed to Newsletter" checkbox and save the customer

Expected:
The customer receives an email with a store-specific email in From header

Actual:
The customer receives an email with default email in From header

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix the newsletter confirmation email From #34963: Fix the newsletter confirmation email From

Fix the newsletter confirmation email From on multi-store env
@m2-assistant
Copy link

m2-assistant bot commented Nov 15, 2021

Hi @sevka. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Nov 18, 2021
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sevka,
Thank you for your contribution!
Could you sign the Adobe CLA and cover your changes with some automated tests?

@sidolov sidolov added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Nov 18, 2021
Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sevka
Thank you for your contribution.
Could you please fix static and unit tests
Thank you in advance.

@Den4ik Den4ik self-requested a review November 26, 2021 08:07
@Den4ik Den4ik self-assigned this Nov 26, 2021
@engcom-Bravo engcom-Bravo self-assigned this Jan 3, 2022
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Bravo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Jan 3, 2022

@sevka Please sign CLA. We could not merge PR without that.

@ihor-sviziev ihor-sviziev removed their assignment Jan 3, 2022
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Bravo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

Hi @sevka,

Thank you for your contribution!

We are not able to proceed further on this PR as you have not sign the Adobe CLA yet. Hence closing this PR.

Please reopen and update if you wish to continue.

Thank you for your contribution!

@Den4ik
Copy link
Contributor

Den4ik commented Jan 12, 2022

@magento create issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Newsletter Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Fix the newsletter confirmation email From
8 participants