Update length of 'increment_id' field for consistency

[fredden]

Description

The 'increment_id' column on the sales_order table does not match other 'increment_id' columns elsewhere in the database. This pull request makes these all match.

Related Pull Requests

None

Fixed Issues

• Fixes increment_id column in sales_order table too short? #34521

Manual testing scenarios

1. Inspect the column definitions of each table containing an 'increment_id' column.

Questions or comments

None

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @fredden. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

✔ Approved.

Failing tests look not related to changes from this PR.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9345 has been created to process this Pull Request

[ihor-sviziev]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

In my opinion this changes is not require any tests and could be moved to merge in progress

[magento-engcom-team]

Hi @Den4ik, thank you for the review.
ENGCOM-9345 has been created to process this Pull Request

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

🎉 All tests are passed

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Magento installation should be having Magento_Sales module (By default, it will be available)

Manual testing scenario:

1. Checked in the sales_order table : increment_id & original_increment_id column lengths are noted (by default it is 32)

2. Apply the PR changes and then execute the below 2 commands from the Magento root folder:

• php bin/magento setup:db-declaration:generate-whitelist --module-name=Magento_Sales
• php bin/magento setup:upgrade

Before: ✖️ increment_id & original_increment_id column lengths were set to 32.

After: ✔️ increment_id & original_increment_id column lengths are now set to 50.

Since it was relevant to DB column length changes, there is no additional additional regression testing is required.