CE#34567: Fix deprecation issues found by integration tests #34781

karyna-t · 2021-12-09T12:47:59Z

Description (*)

Fix deprecation warning found by Integration Tests for PHP 8.1. compatibility

Related Pull Requests

Related Issues

Fix Integration Tests to be compatible with PHP 8.1 #34567

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-12-09T12:48:04Z

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

andrewbess · 2021-12-09T13:10:09Z

@magento run Static Tests

magento-automated-testing · 2021-12-09T13:10:18Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

karyna-t · 2021-12-09T13:32:55Z

app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/PersonalInfo.php

@@ -439,7 +417,8 @@ public function getLastLoginDate()
     */
    public function getStoreLastLoginDate()
    {
-        $date = strtotime($this->getCustomerLog()->getLastLoginAt());
+        $lastLogin = $this->getCustomerLog()->getLastLoginAt();


app/code/Magento/Customer/Model/Logger.php:82

andrewbess · 2021-12-09T15:22:18Z

@magento run all tests

magento-automated-testing · 2021-12-09T15:22:23Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-12-09T18:32:59Z

@magento run Integration Tests, Functional Tests CE, Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2021-12-09T18:33:05Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

xmav · 2021-12-09T20:18:57Z

app/code/Magento/Directory/Model/Currency.php

@@ -488,7 +488,7 @@ private function setOptions(array $options): void
            $this->numberFormatter->setSymbol(\NumberFormatter::CURRENCY_SYMBOL, '');
        }
        if (array_key_exists('precision', $options)) {
-            $this->numberFormatter->setAttribute(\NumberFormatter::FRACTION_DIGITS, $options['precision']);
+            $this->numberFormatter->setAttribute(\NumberFormatter::FRACTION_DIGITS, $options['precision'] ?? 0);


I don't think thats right place for fix. There are few places that use null as a value for precision while default is 2 \Magento\Framework\Pricing\PriceCurrencyInterface::DEFAULT_PRECISION

magento2/lib/internal/Magento/Framework/Pricing/PriceCurrencyInterface.php

Lines 50 to 56 in 548ac72

public function format(

$amount,

$includeContainer = true,

$precision = self::DEFAULT_PRECISION,

$scope = null,

$currency = null

);

I would ask you to test and see if we really expect\want 0 as precision in
https://github.com/magento/partners-magento2b2b/blob/32b75f9bc94fb4ddf9aa3a07393179554406eab8/app/code/Magento/PurchaseOrder/Ui/Component/Listing/Column/Price.php#L81-L86

https://github.com/magento/partners-magento2b2b/blob/32b75f9bc94fb4ddf9aa3a07393179554406eab8/app/code/Magento/CompanyCredit/Controller/Adminhtml/Index/Reimburse.php#L146-L152

If 0 is desired value please replace null with 0

andrewbess

Hello @karyna-tsymbal-atwix
Thank you for your contribution
Great work ✔️

magento-engcom-team · 2021-12-09T20:56:43Z

Hi @andrewbess, thank you for the review.
ENGCOM-9363 has been created to process this Pull Request
✳️ @andrewbess, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

xmav · 2021-12-09T21:39:44Z

app/code/Magento/Dhl/Model/Carrier.php

@@ -939,7 +940,7 @@ protected function _getDimension($dimension, $configWeightUnit = false)
            );
        }

-        return round($dimension, 3);
+        return $dimension ? round($dimension, 3) : 0.0;


type casting might be more suitable here

Hello @xmav
Thank you for your review
Fixed, please check.

xmav · 2021-12-09T21:42:37Z

app/code/Magento/Customer/Model/Options.php

-            $this->addressHelper->getConfig('prefix_options', $store),
-            $this->addressHelper->getConfig('prefix_show', $store) == NooptreqSource::VALUE_OPTIONAL
-        );
+        $options = $this->addressHelper->getConfig('prefix_options', $store);


please move logic to prepareNamePrefixSuffixOptions()

Hello @xmav
Thank you for your review
Fixed, please check.

xmav · 2021-12-09T22:21:19Z

app/code/Magento/Customer/Model/Options.php

-            $this->addressHelper->getConfig('suffix_show', $store) == NooptreqSource::VALUE_OPTIONAL
-        );
+        $options = $this->addressHelper->getConfig('suffix_options', $store);
+        return $options !== null ? $this->prepareNamePrefixSuffixOptions(


Duplication will be removed in internal PR

xmav · 2021-12-09T22:35:21Z

pending delivery https://github.com/magento-commerce/magento2ce/pull/7303

CE#34567: Fix deprecation issues found by integration tests

b1b6894

magento-engcom-team added Component: CatalogImportExport Component: Customer Component: Dhl Component: Directory Component: GoogleAnalytics Component: Payment Component: Reports Component: Tax Component: User Component: Widget labels Dec 9, 2021

m2-github-services added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 9, 2021

magento-engcom-team added the Release Line: 2.4 label Dec 9, 2021

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Dec 9, 2021

andrewbess added the Project: Platform Health label Dec 9, 2021

karyna-t commented Dec 9, 2021

View reviewed changes

Fixed static tests

54e70fb

andrewbess force-pushed the fix-integration-tests-php-8.1 branch from 401600f to 54e70fb Compare December 9, 2021 18:31

xmav reviewed Dec 9, 2021

View reviewed changes

m2-community-project bot assigned xmav Dec 9, 2021

m2-community-project bot removed the Progress: pending review label Dec 9, 2021

m2-community-project bot added the Progress: review label Dec 9, 2021

The model Currency has been reverted to fix in other PR

8ce2d14

andrewbess force-pushed the fix-integration-tests-php-8.1 branch from 97e0998 to 8ce2d14 Compare December 9, 2021 20:52

andrewbess approved these changes Dec 9, 2021

View reviewed changes

m2-community-project bot assigned andrewbess Dec 9, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Dec 9, 2021

magento-engcom-team removed the Component: Directory label Dec 9, 2021

andrewbess added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: category of expertise labels Dec 9, 2021

xmav reviewed Dec 9, 2021

View reviewed changes

m2-community-project bot added Progress: review and removed Progress: ready for testing labels Dec 9, 2021

CR improvements

143c00b

xmav reviewed Dec 9, 2021

View reviewed changes

magento-engcom-team merged commit 79327ff into magento:2.4-develop Dec 10, 2021

	public function format(
	$amount,
	$includeContainer = true,
	$precision = self::DEFAULT_PRECISION,
	$scope = null,
	$currency = null
	);

CE#34567: Fix deprecation issues found by integration tests #34781

CE#34567: Fix deprecation issues found by integration tests #34781

Uh oh!

Conversation

karyna-t commented Dec 9, 2021

Description (*)

Related Pull Requests

Related Issues

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Dec 9, 2021

Uh oh!

andrewbess commented Dec 9, 2021

Uh oh!

magento-automated-testing bot commented Dec 9, 2021

Uh oh!

karyna-t Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

andrewbess commented Dec 9, 2021

Uh oh!

magento-automated-testing bot commented Dec 9, 2021

Uh oh!

andrewbess commented Dec 9, 2021

Uh oh!

magento-automated-testing bot commented Dec 9, 2021

Uh oh!

xmav Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

andrewbess left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Dec 9, 2021

Uh oh!

xmav Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

andrewbess Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

xmav Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

andrewbess Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

xmav Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

xmav commented Dec 9, 2021

Uh oh!

Uh oh!