Updating Event Argument #35144

manavluhar · 2022-02-25T16:00:14Z

Description (*)

Updating event argument for sales_order_state_change_before event

Fixed Issues (if relevant)

Fixes sales_order_state_change_before Event should give access to order object #26789

Manual testing scenarios (*)

place an observer on sales_order_state_change_before and try to get the data from the actual object

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Adding event argument for sales_order_state_change_before event

m2-assistant · 2022-02-25T16:00:16Z

Hi @manavluhar. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

manavluhar · 2022-02-25T16:01:33Z

@magento run all tests

magento-automated-testing · 2022-02-25T16:01:38Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

manavluhar · 2022-02-28T10:41:58Z

@magento run Static Tests, Functional Tests B2B

magento-automated-testing · 2022-02-28T10:42:06Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Adding meaningful class description.

manavluhar · 2022-02-28T13:53:00Z

@magento run all tests

magento-automated-testing · 2022-02-28T13:53:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

app/code/Magento/Sales/Model/Service/OrderService.php

Co-authored-by: Kristof, Fooman <[email protected]>

manavluhar · 2022-03-02T05:34:48Z

@magento run all tests

magento-automated-testing · 2022-03-02T05:34:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

manavluhar · 2022-03-02T06:45:41Z

@magento run all tests

magento-automated-testing · 2022-03-02T06:45:48Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

manavluhar · 2022-03-02T06:47:37Z

@magento run all tests

magento-automated-testing · 2022-03-02T06:47:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

manavluhar · 2022-03-02T07:38:19Z

@magento run Static Tests

magento-automated-testing · 2022-03-02T07:38:23Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

manavluhar · 2022-03-02T07:40:52Z

@magento run all tests

magento-automated-testing · 2022-05-16T06:40:11Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

manavluhar · 2022-05-16T16:33:44Z

@magento run all tests

magento-automated-testing · 2022-05-16T16:33:48Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2022-05-18T06:13:16Z

@magento run Functional Tests B2B, Integration Tests

magento-automated-testing · 2022-05-18T06:13:25Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2022-05-18T12:48:07Z

@magento run Integration Tests

magento-automated-testing · 2022-05-18T12:48:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2022-06-06T14:41:23Z

@magento give me 2.4.3-p1 with B2b instance

magento-deployment-service · 2022-06-06T14:41:26Z

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2022-06-06T14:42:25Z

Hi @engcom-Lima, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Charlie · 2022-06-07T14:45:12Z

@magento run all tests

magento-automated-testing · 2022-06-07T14:45:19Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-06-09T08:42:20Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests

magento-automated-testing · 2022-06-09T08:42:25Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-06-10T11:27:57Z

Hi @manavluhar,

Thank you for your contribution!

In order to reproduce the issue and test the solution, I have implemented below code base.:

Added sales_order_state_change_before“ event-observer entry in app/code/Magento/Sales/etc/events.xml
Created custom observer for above event
Created new custom controller and load Order and OrderService object in it. Load the order and called $orderService->setState function.
Added debugger points in controller and in observer, in order to reproduce the issue.
Found that we are not getting Order object’s data. Hence issue is reproducible.

✔️ QA Passed
6. Added the PR changes and observed that after PR solution we are getting Order object data correctly.

Also tested all states of order from order grid in admin.

Since the issue is fix and the build is green moving it for merging.

Thank you!

Updating event argument

f9dcba3

Adding event argument for sales_order_state_change_before event

magento-engcom-team added Component: Sales Release Line: 2.4 labels Feb 25, 2022

m2-community-project bot added the Progress: pending review label Feb 25, 2022

Update OrderService.php

dd0720a

Adding meaningful class description.

fooman reviewed Mar 1, 2022

View reviewed changes

app/code/Magento/Sales/Model/Service/OrderService.php Outdated Show resolved Hide resolved

m2-community-project bot assigned fooman Mar 1, 2022

m2-community-project bot added Progress: review and removed Progress: pending review labels Mar 1, 2022

fooman removed their assignment Mar 1, 2022

m2-community-project bot added Progress: pending review and removed Progress: review labels Mar 1, 2022

Updating OrderService.php

8f9a1f5

Co-authored-by: Kristof, Fooman <[email protected]>

Merge branch '2.4-develop' into patch-17

cbe9ad3

Merge branch '2.4-develop' into patch-17

8d9c58c

engcom-Lima self-assigned this May 18, 2022

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels May 18, 2022

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels May 24, 2022

engcom-Charlie self-assigned this Jun 2, 2022

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Jun 3, 2022

This comment was marked as duplicate.

Sign in to view

Merged 2.4-develop

de9f1a8

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Jun 10, 2022

magento-devops-reposync-svc merged commit 7a46709 into magento:2.4-develop Jun 11, 2022

fooman removed their assignment Jul 2, 2025

Updating Event Argument #35144

Updating Event Argument #35144

Uh oh!

Conversation

manavluhar commented Feb 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Feb 25, 2022

Uh oh!

manavluhar commented Feb 25, 2022

Uh oh!

magento-automated-testing bot commented Feb 25, 2022

Uh oh!

manavluhar commented Feb 28, 2022

Uh oh!

magento-automated-testing bot commented Feb 28, 2022

Uh oh!

manavluhar commented Feb 28, 2022

Uh oh!

magento-automated-testing bot commented Feb 28, 2022

Uh oh!

Uh oh!

manavluhar commented Mar 2, 2022

Uh oh!

magento-automated-testing bot commented Mar 2, 2022

Uh oh!

manavluhar commented Mar 2, 2022

Uh oh!

magento-automated-testing bot commented Mar 2, 2022

Uh oh!

manavluhar commented Mar 2, 2022

Uh oh!

magento-automated-testing bot commented Mar 2, 2022

Uh oh!

manavluhar commented Mar 2, 2022

Uh oh!

magento-automated-testing bot commented Mar 2, 2022

Uh oh!

manavluhar commented Mar 2, 2022

Uh oh!

magento-automated-testing bot commented May 16, 2022

Uh oh!

manavluhar commented May 16, 2022

Uh oh!

magento-automated-testing bot commented May 16, 2022

Uh oh!

engcom-Lima commented May 18, 2022

Uh oh!

magento-automated-testing bot commented May 18, 2022

Uh oh!

engcom-Lima commented May 18, 2022

Uh oh!

magento-automated-testing bot commented May 18, 2022

Uh oh!

This comment was marked as duplicate.

engcom-Lima commented Jun 6, 2022

Uh oh!

magento-deployment-service bot commented Jun 6, 2022

Uh oh!

magento-deployment-service bot commented Jun 6, 2022

Uh oh!

engcom-Charlie commented Jun 7, 2022

Uh oh!

magento-automated-testing bot commented Jun 7, 2022

Uh oh!

engcom-Charlie commented Jun 9, 2022

Uh oh!

magento-automated-testing bot commented Jun 9, 2022

Uh oh!

engcom-Charlie commented Jun 10, 2022

Uh oh!

Uh oh!

manavluhar commented Feb 25, 2022 •

edited

Loading