Disable max session size in admin - Unable to login to admin anymore …

[nisha-vaghela]

…#35312

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Disable max session size in admin - Unable to login to admin anymore #35312

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @nisha-vaghela. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[nisha-vaghela]

@magento give me test instance

[magento-deployment-service]

Hi @nisha-vaghela. Thank you for your request. I'm working on Magento instance for you.

[nisha-vaghela]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @nisha-vaghela. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @nisha-vaghela, here is your Magento Instance: https://51024ebbf04f2af9193e726791436cd1.instances.magento-community.engineering
Admin access: https://51024ebbf04f2af9193e726791436cd1.instances.magento-community.engineering/admin_deda
Login: f9eaf726
Password: 8be6d25c3311

[magento-deployment-service]

Hi @nisha-vaghela, here is your Magento Instance: https://59dcb47fabb57c1f6e2dbabad9c12884.instances.magento-community.engineering
Admin access: https://59dcb47fabb57c1f6e2dbabad9c12884.instances.magento-community.engineering/admin_e2c7
Login: bee1f721
Password: 2a7bc3b018fa

[ihor-sviziev]

Hi @nisha-vaghela,
Your changes look good.
Could you please cover your changes with some automated test?
Thank you!

[glo71317]

Based on the priority we are working on the automation test and will deliver soon for 2.4.5 release

[engcom-Alfa]

We raised internal PR-https://github.com/magento-gl/magento2ce/pull/288 along with this PR commits, and covering the automation tests and resolved PR comments.
Once Internal PR will get merged, will notify here

[ihor-sviziev]

@engcom-Alfa, Is there any reason you can't add commits to this PR and then merge it?

[glo71317]

@engcom-Alfa, Is there any reason you can't add commits to this PR and then merge it?

We have added your commits in our PR, So no worries :)