Skip empty options even when the SkipCheckRequiredOption flag is true

[Zaahed]

Description (*)

A conditional is added to skip empty string options so that they are not included when adding a product to a quote.

Including empty string values will add an error to the quote item because \Magento\Catalog\Model\Product\Option::getValueById is unable to find a value for an empty string and therefore returns null, causing the else statement to be run in \Magento\Catalog\Model\Product\Option\Type\Select::getOptionSku which adds an error to the listener:
$this->getListener()->setHasError(true)->setMessage($this->_getWrongConfigurationMessage());.

This adds the Some of the selected options are not currently available. error in \Magento\Quote\Model\Quote\Item\AbstractItem::checkData to itself.

Fixed Issues (if relevant)

1. Fixes Imposible to reorder configurable products with optional custom options #35409

Manual testing scenarios (*)

1. Create a new product.
2. Add a custom dropdown option to the new product and uncheck 'Required' checkbox.
3. Order the product through the frontend without any custom options selected.
4. Reorder from the admin view (Sales -> Order -> View Order -> Reorder).

Before the change:
An error message is shown Some of the selected options are not currently available., forcing the user to use a workaround.
The Submit Order button redirects the user to the same page with the error message, no order is created.

After the change:
No error message is displayed, order can be created as usual.

Questions or comments

My first PR here. I still need to figure out how tests work and whether I need to do any tests.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Zaahed. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Zaahed]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.