-
Notifications
You must be signed in to change notification settings - Fork 24
DOCSP-49053: Standardize MongoClient page #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-49053: Standardize MongoClient page #621
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly small fixes. I also noticed that the Connection targets page has no content: https://deploy-preview-621--docs-csharp.netlify.app/connect/connection-targets/
source/connect/mongoclient.txt
Outdated
For a full list of the settings you can configure, see the | ||
`MongoClientSettings <{+new-api-root+}/MongoDB.Driver/MongoDB.Driver.MongoClientSettings.html>`_ | ||
API documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: link to on domain settings docs: https://deploy-preview-621--docs-csharp.netlify.app/connect/connection-options/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to reply to your top level comment, Connection Targets is a separate PR currently in External Review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments but can take a look again if you want!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49053
Staging Links
Self-Review Checklist