Skip to content

DOCSP-49053: Standardize MongoClient page #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Apr 28, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49053

Staging Links

  • connect/mongoclient
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Apr 28, 2025

    Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit df023aa
    🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/6813713c1dcb64000866d896
    😎 Deploy Preview https://deploy-preview-621--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Mostly small fixes. I also noticed that the Connection targets page has no content: https://deploy-preview-621--docs-csharp.netlify.app/connect/connection-targets/

    Comment on lines 114 to 116
    For a full list of the settings you can configure, see the
    `MongoClientSettings <{+new-api-root+}/MongoDB.Driver/MongoDB.Driver.MongoClientSettings.html>`_
    API documentation.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Just to reply to your top level comment, Connection Targets is a separate PR currently in External Review!

    @mcmorisi mcmorisi requested a review from rustagir April 29, 2025 14:37
    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    minor comments but can take a look again if you want!

    @mcmorisi mcmorisi requested review from a team and rstam and removed request for a team April 30, 2025 14:13
    Copy link
    Collaborator

    @rstam rstam left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mcmorisi mcmorisi merged commit 1fe89e9 into mongodb:docsp-45382-comp-cvg May 1, 2025
    2 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-49053-create-client branch May 1, 2025 13:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants