Skip to content

DOCSP-49811 - ClientSessionOptions #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented May 6, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49811

Staging Links

  • crud/transactions
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented May 6, 2025

    Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit b41afb7
    🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/681a58724557670008659e0f
    😎 Deploy Preview https://deploy-preview-627--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @norareidy norareidy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM with some comments!

    | **Default**: ``true``

    * - ``DefaultTransactionOptions``
    - The default transaction options for the session. This includes the maximum commit
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: I'd start with the verb to match the other descriptions

    Suggested change
    - The default transaction options for the session. This includes the maximum commit
    - Specifies the default transaction options for the session. This includes the maximum commit

    Comment on lines 51 to 52
    .. code-block::

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: add the language here; also applies to the other code block

    Suggested change
    .. code-block::
    .. code-block::
    :language: csharp

    @mongoKart mongoKart force-pushed the docsp-49811-clientSessionOptions branch from ef460a4 to f4ce348 Compare May 6, 2025 18:11
    @mongoKart mongoKart requested review from a team and adelinowona and removed request for a team May 6, 2025 18:50
    Copy link

    @adelinowona adelinowona left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @mongoKart mongoKart merged commit 60e0cca into mongodb:docsp-45382-comp-cvg May 8, 2025
    6 checks passed
    @mongoKart mongoKart deleted the docsp-49811-clientSessionOptions branch May 8, 2025 13:36
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants