-
Notifications
You must be signed in to change notification settings - Fork 24
DOCSP-49811 - ClientSessionOptions #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-49811 - ClientSessionOptions #627
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some comments!
source/crud/transactions.txt
Outdated
| **Default**: ``true`` | ||
|
||
* - ``DefaultTransactionOptions`` | ||
- The default transaction options for the session. This includes the maximum commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: I'd start with the verb to match the other descriptions
- The default transaction options for the session. This includes the maximum commit | |
- Specifies the default transaction options for the session. This includes the maximum commit |
source/crud/transactions.txt
Outdated
.. code-block:: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: add the language here; also applies to the other code block
.. code-block:: | |
.. code-block:: | |
:language: csharp |
ef460a4
to
f4ce348
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49811
Staging Links
Self-Review Checklist