Cannot Open after Dispose

[bgrainger]

Connector/NET allows the following code:

var connection = new MySqlConnection("connection string");
connection.Open();
connection.Dispose();
connection.Open();

MySqlConnector throws an ObjectDisposedException on the last line.

In practice, this could happen if a MySqlConnection object was captured by a lambda inside a using block, then invoked after the connection is disposed.

[ejball]

IMHO, the current behavior is correct and superior; the Connector/NET behavior could mask bugs.

If someone really wants the Connector/NET behavior, e.g. because they don't want to fix legacy code, perhaps we should add (yet) another connection setting?

[NateMerritt]

I also agree that MySqlConnector has correct behavior over Connector/NET. This might be something to mention in the migration docs; I don't know if it's worth "fixing" or adding a new connection setting.

[bgrainger]

FWIW, SqlConnection.Dispose() has the side-effect of clearing the connection string, so this "pattern" doesn't work with it. (It won't throw ObjectDisposedException, but Open will throw InvalidOperationException: The ConnectionString property has not been initialized.)

I haven't tested Npgsql, but NpgsqlConnection.Open calls Open(...) which calls CheckConnectionClosed which calls CheckDisposed which throws if _disposed is true, and that is set in Dispose. So it appears this wouldn't work with Npgsql either.

I think updating the documentation is the correct approach here.