Skip to content

revives: Move typetraits.$ to system. Fixes #5827 ; fixes #7976 #10071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 30, 2018
Merged

revives: Move typetraits.$ to system. Fixes #5827 ; fixes #7976 #10071

merged 4 commits into from
Dec 30, 2018

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Dec 21, 2018 •
edited
Loading

@timotheecour timotheecour mentioned this pull request Dec 21, 2018
Closed
@timotheecour timotheecour reopened this Dec 22, 2018
@dom96
Copy link
Contributor

dom96 commented Dec 22, 2018

Thank you for this @timotheecour.

@Araq seeing you close PRs without a comment explaining why is really demoralising.

@timotheecour
Copy link
Member Author

timotheecour commented Dec 22, 2018 •
edited
Loading

btw: on my todo list for this pr is using a template name instead of proc in typetraits, will try today
EDIT: done

@Araq
Copy link
Member

Araq commented Dec 22, 2018

@Araq seeing you close PRs without a comment explaining why is really demoralising.

I did explain why. Nobody bothered to make the CIs green for a long time.

@dom96
Copy link
Contributor

dom96 commented Dec 22, 2018

I did explain why. Nobody bothered to make the CIs green for a long time.

No you haven't. Your last comment was 10 days ago and you didn't explicitly say "I am closing this because CIs aren't green".

@timotheecour timotheecour mentioned this pull request Dec 23, 2018
Closed
@timotheecour timotheecour mentioned this pull request Dec 23, 2018
Open
@timotheecour
Copy link
Member Author

/cc @Araq @dom96 PTAL, CI finally green

alaviss
alaviss reviewed Dec 23, 2018
View reviewed changes
@timotheecour
Copy link
Member Author

ping @dom96

@timotheecour
Copy link
Member Author

PTAL

@Araq Araq merged commit 0831292 into nim-lang:devel Dec 30, 2018
@timotheecour timotheecour deleted the pull_7100 branch December 30, 2018 01:12
This was referenced Jan 2, 2019
Closed
Closed
@timotheecour timotheecour changed the title revives: Move typetraits.$ to system. Fixes #5827 revives: Move typetraits.$ to system. Fixes #5827 ; fixes #7976 Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

@alaviss alaviss alaviss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[typetraits] Tuple type name confusion Nim beginner's feedback: "echo type(1)" does not work
4 participants
@timotheecour @dom96 @Araq @alaviss