@npmcli/[email protected]

Author: isaacs

lib/config/set-envs.js

@@ -8,11 +8,14 @@
 // and the value is a string or array.  Otherwise return false.
 const envKey = (key, val) => {
   return !/^[/@_]/.test(key) &&
-    (typeof val === 'string' || Array.isArray(val)) &&
-    `npm_config_${key.replace(/-/g, '_').toLowerCase()}`
+    (typeof envVal(val) === 'string') &&
+      `npm_config_${key.replace(/-/g, '_').toLowerCase()}`
 }
 
-const envVal = val => Array.isArray(val) ? val.join('\n\n') : val
+const envVal = val => Array.isArray(val) ? val.map(v => envVal(v)).join('\n\n')
+  : val === null || val === undefined || val === false ? ''
+  : typeof val === 'object' ? null
+  : String(val)
 
 const sameConfigValue = (def, val) =>
   !Array.isArray(val) || !Array.isArray(def) ? def === val
@@ -30,20 +33,48 @@ const sameArrayValue = (def, val) => {
   return true
 }
 
+const setEnv = (rawKey, rawVal) => {
+  const val = envVal(rawVal)
+  const key = envKey(rawKey, val)
+  if (key)
+    process.env[key] = val
+}
+
 const setEnvs = npm => {
-  // The objects in the config.list array are arranged in
-  // a prototype chain, so we can just for/in over the top
-  // of the stack and grab any that don't match the default
-  const { config: { list: [configs] } } = npm
+  // This ensures that all npm config values that are not the defaults are
+  // shared appropriately with child processes, without false positives.
+  //
+  // if the key is the default value,
+  //   if the environ is NOT the default value,
+  //     set the environ
+  //   else skip it, it's fine
+  // if the key is NOT the default value,
+  //   if the env is setting it, then leave it (already set)
+  //   otherwise, set the env
+  console.error(npm.config.list)
+  const { config: { list: [cli, env] } } = npm
+  const cliSet = new Set(Object.keys(cli))
+  const envSet = new Set(Object.keys(env))
   const { defaults } = require('./defaults.js')
-  for (const key in configs) {
-    const val = configs[key]
-    const environ = envKey(key, val)
-    if (!sameConfigValue(defaults[key], val) && environ) {
-      process.env[environ] = envVal(val)
+  // the configs form a prototype chain, so we can for/in over cli to
+  // see all the current values, and hasOwnProperty to see if it's
+  // set therre.
+  for (const key in cli) {
+    if (sameConfigValue(defaults[key], cli[key])) {
+      if (!sameConfigValue(defaults[key], env[key])) {
+        // getting set back to the default in the cli config
+        setEnv(key, cli[key])
+      }
+    } else {
+      // config is not the default
+      if (!(envSet.has(key) && !cliSet.has(key))) {
+        // was not set in the env, so we have to put it there
+        setEnv(key, cli[key])
+      }
     }
   }
 
+  // also set some other common ones.
   process.env.npm_execpath = require.main.filename
   process.env.npm_node_execpath = process.execPath
   process.env.npm_command = npm.command

node_modules/@npmcli/run-script/README.md

@@ -44,7 +44,7 @@
   "dependencies": {
     "@npmcli/arborist": "^0.0.16",
     "@npmcli/ci-detect": "^1.2.0",
-    "@npmcli/run-script": "^1.4.0",
+    "@npmcli/run-script": "^1.5.0",
     "abbrev": "~1.1.1",
     "ansicolors": "~0.3.2",
     "ansistyles": "~0.1.3",