MAINT: defer the import of shutil #18278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy/lib/_datasource.py
is going through the hoops deferring the import oflzma
andbz2
until needed:numpy/numpy/lib/_datasource.py
Lines 70 to 72 in d5b6b41
However the
lzma
andbz2
modules were already loaded duringimport shutil
earlier:https://github.com/python/cpython/blob/49926cf2bcc8b44d9b8f148d81979ada191dd9d5/Lib/shutil.py#L21-L33
Also deferring the import of
shutil
reduces the initial numpy import time by almost 5% on my system.