Skip to content

BUG: PPC64el machines are POWER for Fortran #8659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2017

Conversation

matthew-brett
Copy link
Contributor

Fix Fortran kind detection for PPC64el.

See: gh-3424.

Fix Fortran kind detection for PPC64el.

See: numpygh-3424.
@charris
Copy link
Member

charris commented Feb 22, 2017

Have you tested on SPARC? Otherwise, LGTM.

@charris
Copy link
Member

charris commented Feb 22, 2017

BTW, you should be able to attach labels. If not we need to increase your permissions.

@matthew-brett
Copy link
Contributor Author

Yes, I can apply labels - sorry - just didn't think to do it.

The SPARC machine I sometimes have access to is down at the moment, but I'm confident that the machine.platform() string does not start with 'ppc64'. In fact, on Debian, I happen to know it's 'sparc64' (https://github.com/nipy/nibabel/blob/master/nibabel/casting.py#L668) .

@charris
Copy link
Member

charris commented Feb 22, 2017

Oops, I meant on a PPC machine. For some reason I see Matthew and think SPARC...

@matthew-brett
Copy link
Contributor Author

:) - not sure how I feel about being Mr SPARC - but - I don't actually have access to a 'power' machine - I guess these were Mac G4s running OSX? This test does pass on a big-endian 'ppc64' machine running Debian.

@charris
Copy link
Member

charris commented Feb 22, 2017

Guess we'll put it out there and see if it helps, certainly looks straightforward. Thanks Matthew.

@charris charris merged commit 9002b7b into numpy:master Feb 22, 2017
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Feb 23, 2017
@charris charris added this to the 1.12.1 release milestone Feb 23, 2017
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Mar 4, 2017
@charris charris removed this from the 1.12.1 release milestone Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants