Skip to content

Commit 0c8cc2c

Browse files
Xin LiuDamonFool
authored andcommitted
8258058: improve description of OutOfMemoryError relevant flags
OutOfMemoryError thrown out of JVM doesn't notify hotspot, so debug.cpp::report_java_out_out_memory does not handle it. ie. Some options don't respect OOMEs from Java libraries. We need to make the description more clear to users. Reviewed-by: dholmes, jiefu
1 parent cdb5342 commit 0c8cc2c

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/hotspot/share/runtime/globals.hpp

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,8 @@ const intx ObjectAlignmentInBytes = 8;
541541
"for examples") \
542542
\
543543
product(ccstrlist, OnOutOfMemoryError, "", \
544-
"Run user-defined commands on first java.lang.OutOfMemoryError") \
544+
"Run user-defined commands on first java.lang.OutOfMemoryError " \
545+
"thrown from JVM") \
545546
\
546547
product(bool, HeapDumpBeforeFullGC, false, MANAGEABLE, \
547548
"Dump heap to file before any major stop-the-world GC") \
@@ -550,7 +551,8 @@ const intx ObjectAlignmentInBytes = 8;
550551
"Dump heap to file after any major stop-the-world GC") \
551552
\
552553
product(bool, HeapDumpOnOutOfMemoryError, false, MANAGEABLE, \
553-
"Dump heap to file when java.lang.OutOfMemoryError is thrown") \
554+
"Dump heap to file when java.lang.OutOfMemoryError is thrown " \
555+
"from JVM") \
554556
\
555557
product(ccstr, HeapDumpPath, NULL, MANAGEABLE, \
556558
"When HeapDumpOnOutOfMemoryError is on, the path (filename or " \
@@ -867,11 +869,12 @@ const intx ObjectAlignmentInBytes = 8;
867869
range(0, 2) \
868870
\
869871
product(bool, ExitOnOutOfMemoryError, false, \
870-
"JVM exits on the first occurrence of an out-of-memory error") \
872+
"JVM exits on the first occurrence of an out-of-memory error " \
873+
"thrown from JVM") \
871874
\
872875
product(bool, CrashOnOutOfMemoryError, false, \
873876
"JVM aborts, producing an error log and core/mini dump, on the " \
874-
"first occurrence of an out-of-memory error") \
877+
"first occurrence of an out-of-memory error thrown from JVM") \
875878
\
876879
/* tracing */ \
877880
\

0 commit comments

Comments
 (0)