[GR-31691] Initial JFR support. #3444

christianhaeubl · 2021-06-02T09:26:05Z

No description provided.

Cleanups.

…ration thread

…odule

* Merge JfrSerializer interface into JfrRepository * Add comment about repository ordering * Move symbolRepo after methodRepo and stackTraceRepo

* Reintroduced the JfrSerializerSupport. * Renamed JfrRepository to JfrConstantPool. * Removed all TODOs. * Removed unused classes. * Disallow Java synchronization in VM operations. * Moved UninterruptibleHashTable. * Moved all JFR test cases. * Only enable JFR on JDK11. * Minor style-related changes. * Disable writing thread start/end events until we have more of the thread-related JFR infrastructure. * Fixed issue regarding uninterruptible. * Removed more unused code.

christianhaeubl · 2021-06-02T09:37:33Z

@jiekang : instead of a rebase, I used a more selective approach. This changed the hashes of the following RedHat commits: 8f220de, 9bbfeaf, and 4e53401. All other commits are either my own or they should have the same hash as in your jfr-backup branch.

graalvmbot · 2021-06-02T09:40:11Z

Hello Jie Kang, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address jkang -(at)- redhat -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

Hello Victor Ma, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address vma -(at)- redhat -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

jiekang · 2021-06-02T14:01:57Z

Hello Jie Kang, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address jkang -(at)- redhat -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

Hello Victor Ma, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address vma -(at)- redhat -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

Both Jie and Victor ([email protected] and [email protected]) are Red Hat employees and I believe have the OCA signed on their behalf.

jiekang · 2021-06-02T14:09:25Z

@jiekang : instead of a rebase, I used a more selective approach. This changed the hashes of the following RedHat commits: 8f220de, 9bbfeaf, and 4e53401. All other commits are either my own or they should have the same hash as in your jfr-backup branch.

Okay. I think the commit contents and authors look fine. Thank you.

graalvmbot · 2021-06-07T08:00:17Z

Jie Kang has signed the Oracle Contributor Agreement (based on email address jkang -(at)- redhat -(dot)- com) so can contribute to this repository.
Victor Ma has signed the Oracle Contributor Agreement (based on email address vma -(at)- redhat -(dot)- com) so can contribute to this repository.

teshull · 2021-06-08T12:48:06Z

substratevm/src/com.oracle.svm.jfr/src/com/oracle/svm/jfr/traceid/JfrTraceId.java

+    public static final long TRANSIENT_META_BIT = (BIT << 3);
+    public static final long TRANSIENT_BIT = (TRANSIENT_META_BIT << META_SHIFT);
+    public static final long SERIALIZED_META_BIT = (BIT << 4);
+    public static final long SERIALIZED_BIT = (SERIALIZED_META_BIT << META_SHIFT);


It doesn't seem to me like TRANSIENT_BIT or SERIALIZED_BIT can ever be set within a tag.

If so, then these could be deleted, as well as the checks for the TRANSIENT_BIT

Right, those are unused in this incarnation. We might need them later, when (and if) we implement stuff like leak detection, but should probably add them back only when we actually need them. They can be safely removed.

teshull · 2021-06-08T12:50:05Z

substratevm/src/com.oracle.svm.jfr/src/com/oracle/svm/jfr/traceid/JfrTraceIdLoadBarrier.java

+    @Uninterruptible(reason = "Epoch may not change")
+    private static boolean isNotTagged(long value) {
+        long thisEpochBit = JfrTraceIdEpoch.getInstance().thisEpochBit();
+        return ((value & ((thisEpochBit << JfrTraceId.META_SHIFT) | thisEpochBit)) != thisEpochBit);


why is (thisEpochBit << JfrTraceId.META_SHIFT) being checked?

It checks if the Class is tagged as used in the current epoch (as opposed to the previous epoch).

where is the value shifted? I see, JftTraceIdEpoch.changeEpoch(), but is cleanup done somewhere else as well?

I will remove this method and do a few more cleanups as those things are no longer needed anyways.

christianhaeubl and others added 30 commits January 25, 2021 17:20

Partial JFR support.

66374dc

Fixes, cleanups, and a bit more documentation.

7eed9f4

Further fixes.

0a767a8

Added support for pointers to @RawStructure.

399e37f

Minor checkstyle fixes.

d7c57b3

Fixes related to @Uninterruptible.

e968791

Cleanups.

Fixed a class reachability issue.

0199220

Allow Java synchronization for certain VM operations.

5582b1c

Fixes for the JFR startup and teardown.

92956e8

Adjust ThreadListenerSupport before/after calls

870e439

Fix MIN_GLOBAL_BUFFER_SIZE in JfrOptionSet to match jdk 11

f702a89

Adjust chunk writer asserts to account for potential dedicated vm ope…

2613504

…ration thread

Add trace-ID infrastructure

2c8cd72

Remove commented out JfrAvailability checks

9aa336f

Make JfrTypeRepository use trace-Id infra instead of DynamicHub

4710c40

Improved trace-ID mapping

17d9e5a

Build trace-ID indices before compilation; couple of fixes too

283284c

Avoid changes to Feature API

0d9c3ec

Scope metadata collection into a struct-like holder class

38799e3

Avoid atomic counters to init traceIds for package, classloader and m…

0defc54

…odule

Remove unnecessary suite.py change

39ea4ff

In-line the types iteration code from FeatureImpl back into JfrFeature

7925089

Simplify JfrRuntimeAccess

5d6fe23

Reserve index 0 in trace-ID table to catch errors

f7b7c65

Make JfrTraceIdLoadBarrier code uninterruptible

deebccb

Unify JFR ID recomputations for packages, modules and classloaders

41be1bc

Remove stale code

bf45dba

Removed unused imports

a48518c

Few touch-ups

6d3a4a7

Simplify check for system event classes

99fe010

jiekang and others added 18 commits May 5, 2021 11:11

Fix ThreadStart event metadata

48425a4

Make metadata match jdk 11 metadata

213c5ab

Remove custom metadata file and use the HotSpot provided one instead

d1e4584

Merge JfrSerializer interface into JfrRepository (#27)

e6ebfd3

* Merge JfrSerializer interface into JfrRepository * Add comment about repository ordering * Move symbolRepo after methodRepo and stackTraceRepo

Add javadoc comments to all jfr interfaces

a989f87

Fix javadoc comments for jfr interfaces

334cbdc

Remove custom jfc files

1790e35

Added support for writing big endian data to files.

1557050

Implement chunk rotation

bf75304

Add JFR logger support

8f220de

Fix old merge conflict in javadoc comments

9bbfeaf

Add comments to all jfr classes

4e53401

Various cleanups, minor bugfixes, and added more documentation.

ca86dca

Renamed test package.

dd63008

Fixed some documentation.

9daac21

Merge with graal master.

82d4e04

Various fixes.

4a82835

christianhaeubl requested review from christianwimmer and teshull June 2, 2021 09:26

graalvmbot added the oca-signed label Jun 7, 2021

teshull reviewed Jun 8, 2021

View reviewed changes

graalvmbot merged commit 4a82835 into oracle:master Jun 11, 2021

jiekang mentioned this pull request Jun 28, 2021

[WIP] Add JDK Flight Recorder support for Java native images #3070

Closed

jiekang mentioned this pull request Sep 30, 2021

Add JDK Flight Recorder support for Java native images #3018

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[GR-31691] Initial JFR support. #3444

[GR-31691] Initial JFR support. #3444

Uh oh!

christianhaeubl commented Jun 2, 2021

Uh oh!

christianhaeubl commented Jun 2, 2021

Uh oh!

graalvmbot commented Jun 2, 2021

Uh oh!

jiekang commented Jun 2, 2021

Uh oh!

jiekang commented Jun 2, 2021

Uh oh!

graalvmbot commented Jun 7, 2021

Uh oh!

teshull Jun 8, 2021

Uh oh!

rkennke Jun 8, 2021

Uh oh!

teshull Jun 8, 2021

Uh oh!

rkennke Jun 8, 2021

Uh oh!

teshull Jun 8, 2021

Uh oh!

christianhaeubl Jun 8, 2021

Uh oh!

Uh oh!

[GR-31691] Initial JFR support. #3444

[GR-31691] Initial JFR support. #3444

Uh oh!

Conversation

christianhaeubl commented Jun 2, 2021

Uh oh!

christianhaeubl commented Jun 2, 2021

Uh oh!

graalvmbot commented Jun 2, 2021

Uh oh!

jiekang commented Jun 2, 2021

Uh oh!

jiekang commented Jun 2, 2021

Uh oh!

graalvmbot commented Jun 7, 2021

Uh oh!

teshull Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

rkennke Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

teshull Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

rkennke Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

teshull Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

christianhaeubl Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!