yahoo test error connection reset

[cpcloud]

we really need to fix this...

https://travis-ci.org/cpcloud/pandas/jobs/8321921
https://travis-ci.org/cpcloud/pandas/jobs/8322345
https://travis-ci.org/jreback/pandas/jobs/8448538
https://travis-ci.org/pydata/pandas/jobs/8449118 (HTTP error here)

[jreback]

I thought the "@network" was supposed to catch these? are these not IOError?

[cpcloud]

no the error generated is socket.error which is basically a light wrapper around one of the C errno numbers

[jreback]

which apparently is not caught by IOError!
so socket.error should prob be added as a default list of things to catch in '@network'?

[cpcloud]

so wish python 2 had this

[jreback]

should we be catcing OSError then?

[cpcloud]

here's why that might be problem

In [1]: open('asdfasdf', 'r')
---------------------------------------------------------------------------
IOError                                   Traceback (most recent call last)
<ipython-input-1-efa01a311135> in <module>()
----> 1 open('asdfasdf', 'r')

IOError: [Errno 2] No such file or directory: 'asdfasdf'

In [2]: os.path.getsize('asd09g8')
---------------------------------------------------------------------------
OSError                                   Traceback (most recent call last)
<ipython-input-2-0a206a03b7df> in <module>()
----> 1 os.path.getsize('asd09g8')

/home/phillip/.virtualenvs/pandas/lib/python2.7/genericpath.pyc in getsize(filename)
     47 def getsize(filename):
     48     """Return the size of a file, reported by os.stat()."""
---> 49     return os.stat(filename).st_size
     50
     51

OSError: [Errno 2] No such file or directory: 'asd09g8'

[cpcloud]

of course python3 has FileNotFoundError ARG

[cpcloud]

in python3 socket.error is an alias for OSError so i guess we should catch it then...that should work too for connection errors...pr coming in 100..99..98

[jreback]

These are network calls though, the point is to catch them (obviously if we can find a narrow exception would be good)

[cpcloud]

but if there happens to be a file opening error in a python2 test labelled networrk it won't be caught

[jreback]

so let's add the socket exceptions then (in addition to IOError)

[cpcloud]

i did

_network_error_classes = IOError, OSError

try:
    ConnectionError
except NameError:
    _network_error_classes += socket.error,

[cpcloud]

but probably better is

_network_error_classes = IOError,

try:
    _network_error_classes += ConnectionError,
except NameError:
    _network_error_classes += socket.error,

[cpcloud]

this should work in 2.x, 3.x since 3.2 follows py2 conventions regarding exceptions