Skip to content

clean up data.py #4001

Closed
Closed
@cpcloud

Description

@cpcloud
  • remove isinstance(x, str) checks
  • handle urls with context managers
  • get rid of Exception and use appropriate exception types
  • pep8
  • remove redundant parens in conditionals
  • remove \ style line joins
  • range -> xrange
  • functions should not exit after a warning with None they should raise an exception
  • turn all the str + style concats into format strings
  • remove redundant calls to str
  • remove exception handlers with no exception type
  • replace calls to __setattr__ and __getattribute__ with setattr and getattr
  • code coverage at 99%

This should remove the connection reset by peer testing error and I thought I would perform a little housekeeping while I was at it.

Metadata

Metadata

Assignees

Labels

BugIO DataIO issues that don't fit into a more specific labelTestingpandas testing functions or related to the test suite

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions