Skip to content

ENH: Implement core/strings/wrap method #6999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

ENH: Implement core/strings/wrap method #6999

wants to merge 14 commits into from

Conversation

jeffreystarr
Copy link
Contributor

This patch implements the str.wrap function within core/strings.

Example:

    >>> s = pd.Series(['line to be wrapped', 'another line to be wrapped'])
    >>> s.str.wrap(12)
    0             line to be\nwrapped
    1    another line\nto be\nwrapped

This is a cleaned branch; the original is at #6705.

@jeffreystarr
Implementing str_wrap function (matching behavior to R's stringr libr…
643157a 
…ary)
@jeffreystarr
ENH: Implement core/strings/wrap method
ca306c6 
This patch implements the str_wrap function within
core/strings. The implementation follows the behavior
of R's stringr library. When a string is 'wrap'ped,
the return value will be a paragraph with lines of
max(word length, width) length.
@jeffreystarr
Changed implementation to leverage textwrap module, but still retain …
2afa91c 
…R's stringr library defaults and semantics (width being exclusive).
@jeffreystarr
Fixed width default to match documentation.
3017089 
Expanded docstring with description of major optional parameters and added an example.
@jeffreystarr
Added wrap method to table of vectorized string methods
ccb61eb
@jeffreystarr
Added test for non-unicode and NaN input
0aa3fc3
@jeffreystarr
Removed explicit unicode strings (u'') as they are invalid syntax in …
6df4a82 
…Python 3.
@jeffreystarr
Changed width from meaning exclusive width to meaning inclusive width…
686142b 
… (thus matching textwrap module)
@jeffreystarr
Added a non-ascii encodable unicode test
3909217
@jeffreystarr
Made width a required, positional argument (versus an optional, keywo…
e3cba5f 
…rd argument)
@jeffreystarr
Add spaces before colon within docstring
e460eb3
@jeffreystarr
Change example in docstring to use the series.str.wrap form rather th…
ee3fb42 
…an the direct str_wrap form.
@jeffreystarr
Change code to use Python's textwrap defaults rather than R's str_wra…
b91ccd2 
…p defaults
@jeffreystarr
Add reference to pull request to release notes
8428cda
@jreback jreback mentioned this pull request Apr 29, 2014
Closed
@jreback jreback added this to the 0.14.0 milestone Apr 29, 2014
@jreback
Copy link
Contributor

jreback commented Apr 29, 2014

@jorisvandenbossche ok?

@jeffreystarr looks good, i will rebase/squash you on merge

@jorisvandenbossche
Copy link
Member

yep, looking good! (I think all comments were already adressed)

@jreback
Copy link
Contributor

jreback commented Apr 29, 2014

merged via 5b838ab

thanks!

@jreback jreback closed this Apr 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Strings String extension data type and string data
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreystarr @jreback @jorisvandenbossche