BUG: DatetimeIndex with freq raises ValueError when passed value is short #7098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -648,7 +648,8 @@ def infer_freq(index, warn=True): | |||
| raise TypeError("cannot infer freq from a non-convertible index type {0}".format(type(index))) | |||
| index = index.values | |||
|
|
|||
| index = pd.DatetimeIndex(index) | |||
| if not isinstance(index, pd.DatetimeIndex): | |||
There was a problem hiding this comment.
why is this necessary? it should just fall thru
There was a problem hiding this comment.
Not required, removed. (Required in original implementation which I tried to...)
|
this is fine, rebase and can go in |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
DatetimeIndexis created by passingfreqandcheck_integrity=True, passedfreqandinferred_freqmust be identical. But this comparison can fail if length of passed data doesn't have enough length to infer freq.Added additional logic to determine whether passed values are on the passed
freq.