Skip to content

BUG: secondary ax has incorrect right_ax property #9861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BUG: secondary ax has incorrect right_ax property #9861

wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Apr 11, 2015

When secondary_y is enabled, twin axes are created as below:

  • Assume current axes is ax (left ax)
  • create new_ax (right ax) via ax.twinx
  • Let ax.right_ax to specify new_ax (right ax)
  • Let new_ax.left_ax to specify ax (left ax)
  • Let new_ax.right_ax to specify new_ax (incorrect)

The last one is incorrect and confuses other logics such as _get_all_lines. I think it should be removed.

@sinhrks sinhrks force-pushed the incorrect_rightax branch 2 times, most recently from 4cc4364 to f4d68eb Compare April 12, 2015 00:09
@jreback jreback added the Visualization plotting label Apr 12, 2015
@jreback jreback added this to the 0.16.1 milestone Apr 12, 2015
@jreback
Copy link
Contributor

jreback commented Apr 12, 2015

@sinhrks can you rebase

@sinhrks sinhrks force-pushed the incorrect_rightax branch from f4d68eb to 9dee88c Compare April 12, 2015 14:15
@sinhrks
Copy link
Member Author

sinhrks commented Apr 14, 2015

Rebased, and green.

@jreback
Copy link
Contributor

jreback commented Apr 14, 2015

merged via 17132ac

thanks!

@jreback jreback closed this Apr 14, 2015
@sinhrks sinhrks deleted the incorrect_rightax branch April 14, 2015 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Visualization plotting
Projects
None yet
Milestone
0.16.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sinhrks @jreback