BUG: Fix for .extractall (single group with quantifier) #13382 #13397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -708,6 +708,8 @@ def str_extractall(arr, pat, flags=0): | |||
| subject_key = (subject_key, ) | |||
|
|
|||
| for match_i, match_tuple in enumerate(regex.findall(subject)): | |||
| if isinstance(match_tuple, basestring): | |||
| match_tuple = (match_tuple,) | |||
| @@ -335,6 +335,7 @@ Bug Fixes | |||
| - Bug in ``SeriesGroupBy.transform`` with datetime values and missing groups (:issue:`13191`) | |||
|
|
|||
| - Bug in ``Series.str.extractall()`` with ``str`` index raises ``ValueError`` (:issue:`13156`) | |||
| - Bug in ``.extractall()`` with single group and quantifier (:issue:`13382`) | |||
|
minor changes, looks good. ping when green. |
4c5e5d9 to
2afae62
Compare
Current coverage is 84.23%@@ master #13397 diff @@
==========================================
Files 138 138
Lines 50803 50805 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42793 42795 +2
Misses 8010 8010
Partials 0 0
|
|
@jreback Done. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffNote that I had to fix it based on this thread, rather than directly with
[x for x in ['ab']]as this broke previous tests.