Skip to content

Replaces Exceptions with ValueError in MultiIndex, closes #21770 #21780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 7, 2018
Merged

Replaces Exceptions with ValueError in MultiIndex, closes #21770 #21780

merged 5 commits into from
Jul 7, 2018

Conversation

glyg
Copy link
Contributor

@glyg glyg commented Jul 6, 2018

@jreback jreback added Error Reporting Incorrect or improved errors from pandas MultiIndex labels Jul 6, 2018
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. you add a note in Other API breaking changes (technically this is slightly breaking, but no big deal). otherwise lgtm.

@codecov
Copy link

codecov bot commented Jul 7, 2018

Codecov Report

Merging #21780 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21780      +/-   ##
==========================================
+ Coverage   91.95%   91.95%   +<.01%     
==========================================
  Files         160      160              
  Lines       49820    49820              
==========================================
+ Hits        45812    45813       +1     
+ Misses       4008     4007       -1
Flag Coverage Δ
#multiple 90.33% <50%> (ø) ⬆️
#single 42.07% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/multi.py 95.05% <50%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 620abc4...cffaa59. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Jul 7, 2018
@jreback jreback merged commit 876e568 into pandas-dev:master Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas MultiIndex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too generic Exception in multindex reindex raise statement
2 participants