BUG: DataFrame.drop raising TypeError for string label with non-unique MultiIndex and no level provided #38220
Conversation
pandas/core/generic.py
Outdated
| @@ -4173,6 +4173,14 @@ def _drop_axis( | |||
|
|
|||
| # Case for non-unique axis | |||
| else: | |||
| if ( | |||
There was a problem hiding this comment.
should this case only be an issue starting on L4193? e.g. level is None there
There was a problem hiding this comment.
Yep, this is correct. Question is what to do when level is None.
I think ~axis.get_level_values(level).isin(labels) is the way to go, so I check before reaching the if else block if level is None to set it to 0 in this case
There was a problem hiding this comment.
i think setting to level = 0 is fine, i would just move the check inside the block on L4193 as its not going to be true where it is if level is not None in the first place.
There was a problem hiding this comment.
This would work as an alternative
pandas/core/generic.py
Outdated
| @@ -4173,6 +4173,14 @@ def _drop_axis( | |||
|
|
|||
| # Case for non-unique axis | |||
| else: | |||
| if ( | |||
There was a problem hiding this comment.
i think setting to level = 0 is fine, i would just move the check inside the block on L4193 as its not going to be true where it is if level is not None in the first place.
pandas/core/generic.py
Outdated
| labels_missing = (axis.get_indexer_for(labels) == -1).any() | ||
| if errors == "raise" and labels_missing: | ||
| raise KeyError(f"{labels} not found in axis") | ||
| if isinstance(axis, MultiIndex) and labels.dtype == "object": |
|
thanks @phofl |
…e MultiIndex and no level provided (pandas-dev#38220)
DataFrame.dropfails when there is a multiIndex without any level provided #36293black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAs far as I know, isin needs a level input when only a string is given for a MultiIndex. If this should not change, we have to set level=0 in this case.