Skip to content

Remove deprecation warning about 'display.height' option. #4027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

garaud
Copy link
Contributor

@garaud garaud commented Jun 25, 2013

Hi,

See the related issue at #4026

Best regards,
Damien

@jreback
Copy link
Contributor

jreback commented Jun 25, 2013

this is ok, but for 0.12 (I know could be done here, but trying to avoid API changes),

also can you hookup travis?

@garaud
Copy link
Contributor Author

garaud commented Jun 25, 2013

Fine for me for 0.12. I see "Milestone 0.13", close to the pull-request title, was it updated?

"hookup Travis": did you mean that I should activate the Travis hook for my pandas repo ? I sign in. See https://travis-ci.org/garaud/pandas

I'm a "Travis-CI" newbie ;-) I don't know how I can tell to Travis to build this pull-request or this branch, i.e. "display_format". Should I be more patient? I quickly read the doc but I don't find a clearly answer.

@jreback
Copy link
Contributor

jreback commented Jun 25, 2013

0.11.1 was just changed to. 0.12 (as its now a major release
so this will be in next one

look at contributing in the main pandas dir
shows how to hookup up to Travis; u have to hook up
turn it on then push again

lmk if u need help

@garaud
Copy link
Contributor Author

garaud commented Jun 27, 2013

OK. Looks fine See https://travis-ci.org/garaud/pandas/builds/8501905

Note that when I pushed a few hours ago, I saw that the latest commit of the branch master wasn't passed. It deals with the pull request about color_map.

See you.
Damien

@jreback
Copy link
Contributor

jreback commented Jun 27, 2013

yeh....some intermittent network failures on a couple of unreleated tests

@ghost
Copy link

ghost commented Jul 28, 2013

#4391 should silence this, without reintroducing (the useless) height options.
Thanks @garaud for the fix, I thought it best to solve this that way.

Note that 2.7 silences deprecationwarnings by default, which is why I (and I suspect
the other developers) didn't need to scratch this itch ourselves earlier.

might do well for devs/travis to turn this on to get a better feel for latent issues. (cc @cpcloud)

@ghost ghost closed this Jul 28, 2013
@cpcloud
Copy link
Member

cpcloud commented Jul 28, 2013

yes i test on 2.7 ... so i don't see these very often and when i do i ignore them

@y-p good idea to turn on DeprecationWarning reporting for testing.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants