BUG: fix convert_dtypes to handle empty df #40402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a conditional to check a DataFrame had at least one column and if not return the original (empty) DataFrame if so.
Added unit test and added reference to whatsnew
Moved a frame test incorrectly placed in the series hierarchy. Fixed some naming in bug documentation. Changed convert_dtypes to return a copy of apparently empty dataframes
|
Thanks @jorisvandenbossche All good call outs (particularly the test in the wrong place - I should've noticed that). I hope it looks better now. |
rhshadrach
requested changes
Mar 14, 2021
Changed test to use tm.assert_equal and documented error more explicitly
|
Thanks for the feedback @rhshadrach I'm still not sure I've got the assert written the way you'd like - didn't know whether to compare the DataFrame to itself or to a new empty DataFrame. Please let me know if you'd like anything else updated. |
Replaced tm.assert_equals with tm.assert_frame_equals
jorisvandenbossche
approved these changes
Mar 15, 2021
|
Thanks a lot @owenlamont for your first contribution! |
|
Thank you! I'm honoured to contribute to such a foundational part of the PyData ecosystem. First of many hopefully. |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a conditional to check a DataFrame had at least one column and if not return the original (empty) DataFrame if so.