BUG: concat of bool and boolean giving object dtype #43409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mzeitlin11
commented
Sep 4, 2021
- closes BUG: concat behaves differently for bool/boolean dtypes than it does for int64/Int64 #42800
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
requested changes
Sep 5, 2021
| @@ -597,6 +597,15 @@ def test_concat_preserves_extension_int64_dtype(): | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_concat_bool_boolean(): | |||
There was a problem hiding this comment.
can you parameterize and also include a bool series here as a test (e.g. no boolean, just plain bool)
There was a problem hiding this comment.
Have added other combinations
jreback
approved these changes
Sep 7, 2021
| # Handle only boolean + np.bool_ -> boolean, since other cases like | ||
| # Int64 + boolean -> Int64 will be handled by the other type | ||
| if all( | ||
| isinstance(t, BooleanDtype) |
There was a problem hiding this comment.
is_bool_dtype should work here no?
that said i think we are using mostly this type of pattern, which i am actually not much of a fan of. so ok for this PR. but we should ideally be using the common accessors rather than writing new ones for EA types, can you open an issue about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.