BUG: fix rolling with centering and axis=1 (#46135) #46265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 7, 2022 22:52
mroeschke
reviewed
Mar 11, 2022
added 2 commits
March 22, 2022 23:02
…to jyuv-contribution � Conflicts: � pandas/tests/window/test_rolling.py
|
@github-actions pre-commit |
mroeschke
reviewed
Mar 22, 2022
…to jyuv-contribution � Conflicts: � pandas/tests/window/test_rolling.py
|
@github-actions pre-commit |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Hi, |
|
You will need to merge main and push to this branch again. Looks like previously the CI didn't run all the jobs |
…ibution � Conflicts: � pandas/tests/window/test_win_type.py
mroeschke
reviewed
Apr 30, 2022
mroeschke
reviewed
Apr 30, 2022
mroeschke
approved these changes
May 2, 2022
|
Thanks @jyuv |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…-dev#46265) * TST: added test for rolling with centering=True and axis=1 (pandas-dev#46135) * BUG: fixed bug of rolling with centering=True and axis=1 (pandas-dev#46135) * DOC: fixed bug of rolling with centering=True and axis=1 (pandas-dev#46135) * Fixes from pre-commit [automated commit] * TST: adapted test_rolling_center_axis_1 to support check_dtype=True * Fixes from pre-commit [automated commit] * TST: move test_rolling_center_axis_1 from test_rolling.py to test_win_type.py * Fixes from pre-commit [automated commit] * DOC: moved bug mention to rolling doc section and specify conditions (pandas-dev#46135) Co-authored-by: Yuval <yuval,[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.