io.pytables: handle start/stop in remove and select_coords #4835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need:
thanks! |
|
Thanks for your feedback. I can do this next this week. What exactly is needed to "hook up to travis", I did not find anything about this in the deveolpoer page. |
|
look at contributing.md in main pandas dir |
|
@cpcloud maybe add a link on developer page? |
|
@wabu how's this coming? |
|
sorry. caught a bad cold, now added missing bits |
|
no problem! fyi...you will need to rebase that master out of their
|
|
@wabu can you rebase this? |
|
I did a rebase, the test is still failing on python 2.7, did not have time to debug this as i don't have a numpy/pytables/pandas for 2.7 around |
|
Travis builds the pr automatically https://travis-ci.org/pydata/pandas/jobs/17820546 |
|
look at #6177 for fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the start/stop arguments to HDFStore.remove are ignored, so I have a patch to make them work as expected. Moreover I changed Selection.select_coords to also apply start and stop.