BUG/CLN: fix iloc when positional indexer matched Int64Index key #6614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll add tests & release notes later tonight. |
|
looks good |
Also, drop takeable parameter from reindex(...) function family.
|
I've added this as a bug fix as it technically fixed a bug with |
jreback
added a commit
that referenced
this pull request
Mar 12, 2014
BUG/CLN: fix iloc when positional indexer matched Int64Index key
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6612
As discussed in #6612,
reindex(..., takeable=True)as released in 0.13.0 didn't do anything that's not achieved by.take,.ilocand.copyattrs/methods, but also contained a bug which propagated toilocwhen the latter was changed to use reindex/takeable internally.The proposed solution is to remove reindex/takeable functionality altogether. According to @jreback, it was never supposed to be a part of public API, so probably no deprecation procedure is necessary.