BUG: DataFrame._reduce was converting integers to strings in mixed-type case. #6814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls add a release note and good 2 go |
case. BUG: Remove creating np.array. This allows us to use our own logic for promoting dtypes. pandas-dev#6806 BUG: Only convert 0/1 ints to bool. pandas-dev#6806 DOC: added release notes
|
@jreback g2g |
|
k....in general also nice to rebase when adding something (don't worry in this case though). as it makes merging very easy. |
|
I thought I did rebase and squash. Well, it should be rebased from an hour or two ago. |
|
I had just pushed something.....:) |
|
thanks! |
|
lol. I had to wait for travis to ping green! /me searches for some github lock command. |
|
what I usually do is see that the auto-merge is indicated, if not, pull, fix, and repush |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6806