ENH: Implement Series.StringMethod.slice_replace #9014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty good to me. We are about to release 0.15.1, so after we do that please add release notes for this new feature. |
|
Sure, I'll add a release note and rebase after the release drops. |
|
@billletson 0.15.2 has been released, so you can go ahead and add release notes now for 0.16.0. |
a655f5c to
623c373
Compare
|
@billletson sorry, I was not paying attention earlier. Could you please rebase again and ping me when the tests pass so I can do the merge? Github does not send out notifications of new commits without a comment :/. |
623c373 to
aa3aaa5
Compare
|
@shoyer rebased and build passing, good to go |
shoyer
added a commit
that referenced
this pull request
Jan 8, 2015
ENH: Implement Series.StringMethod.slice_replace
|
Thanks! |
|
@billletson this is nice. maybe stick an example in here somewhere: http://pandas-docs.github.io/pandas-docs-travis/text.html ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8888
This does not implement immerrr's suggestion of implementing
__setitem__, as allStringMethodmethods return a newSeries(orDataFrame) rather than mutating.