Skip to content

zend_weakrefs #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

zend_weakrefs #3934

wants to merge 6 commits into from

Conversation

krakjoe
Copy link
Member

@krakjoe krakjoe commented Mar 11, 2019

This is the amended implementation for weakrefs RFC

@krakjoe krakjoe mentioned this pull request Mar 11, 2019
Closed
@krakjoe krakjoe added the RFC label Mar 11, 2019
@krakjoe
fix odd ball com_dotnet objects that don't call std_dtor
39d5616 
export notify for those extensions in the wild with non-standard dtor routine
nikic
nikic reviewed Mar 11, 2019
View reviewed changes
krakjoe added 4 commits March 11, 2019 09:59
@krakjoe
use std_dtor
f68bd4b
@krakjoe
drop clone
80fff47 
use zend_object* instead of zval
rename in decls
don't export non-existent things
@krakjoe
[ci skip] ws
86b5272
@krakjoe
of -> create
53e99ad
@krakjoe
Copy link
Member Author

krakjoe commented Mar 11, 2019

Merged 6529d7a

@krakjoe krakjoe closed this Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krakjoe @nikic