[core] Fix renderer tests for windows builds #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove platform-dependent contents from the file names to prevent tests breaking on Windows systems.
|
Fixes #2067 |
Generated by 🚫 Danger |
adangel
reviewed
Oct 16, 2019
pmd-core/src/test/java/net/sourceforge/pmd/renderers/SummaryHTMLRendererTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR, please check that:
master../mvnw clean verifypasses.PR Description:
Remove the platform-specific file separators from the test cases and does some cleaning work.
Before, there were many instances of the
sourcecodeFilenamebeing hard-coded into the dest data. This PR also cleans up the tests so that they will always rely on the values returned by a utility method (most commonlyAbstractRendererTest#getSourceCodeFilename.Fixes #2067