Skip to content

[java] Created fix for UselessStringValueOf false positive #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2021
Merged

[java] Created fix for UselessStringValueOf false positive #3612

merged 2 commits into from
Nov 18, 2021

Conversation

johnra2
Copy link
Contributor

@johnra2 johnra2 commented Nov 12, 2021 •
edited by adangel
Loading

@adangel adangel changed the title Created fix for UselessStringValueOf false positive [java] Created fix for UselessStringValueOf false positive Nov 12, 2021
adangel
adangel requested changes Nov 12, 2021
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!
Please have a look at my comment

@adangel adangel added this to the 6.41.0 milestone Nov 18, 2021
@adangel adangel self-assigned this Nov 18, 2021
@ghost
Copy link

ghost commented Nov 18, 2021

1 Message
📖 This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 3 configuration errors.
Full report

Generated by 🚫 Danger

adangel added a commit that referenced this pull request Nov 18, 2021
@adangel
[doc] Update release notes (#3491, #3612)
2e2ad6e
adangel added a commit that referenced this pull request Nov 18, 2021
@adangel
Merge pull request #3612 from johnra2:3491-uselessstringvalueof-fp-ch…
7609a24 
…ar-array

[java] Created fix for UselessStringValueOf false positive #3612

* pr-3612:
  [doc] Update release notes (#3491, #3612)
  Add @johnra2 as a contributor
  [java] UselessStringValueOf - skip String.valueOf with more than one arg
  Created fix for UselessStringValueOf false positive
@adangel adangel merged commit 1393e7d into pmd:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel requested changes

Assignees

@adangel adangel

Labels
None yet
Projects
None yet
Milestone
6.41.0
Development

Successfully merging this pull request may close these issues.

[java] UselessStringValueOf: False positive when valueOf(char [], int, int) is used
2 participants
@johnra2 @adangel