Skip to content

Fix build due to new checks in PostgreSQL 16 #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Fix build due to new checks in PostgreSQL 16 #256

merged 1 commit into from
Nov 18, 2022

Conversation

MarinaPolyakova
Copy link
Contributor

Due to the commit c8b2ef05f481ef06326d7b9f3eb14b303f215c7e in PostgreSQL 16:

  • The macro CStringGetTextDatum returns a Datum, so use the more appropriate macro PG_RETURN_DATUM instead of PG_RETURN_TEXT_P.

  • The input to the macro TextDatumGetCString must be of type Datum, so use the more appropriate macro PG_GETARG_DATUM instead of PG_GETARG_TEXT_P.

Due to the commit c8b2ef05f481ef06326d7b9f3eb14b303f215c7e in PostgreSQL 16:

- The macro CStringGetTextDatum returns a Datum, so use the more appropriate
  macro PG_RETURN_DATUM instead of PG_RETURN_TEXT_P.

- The input to the macro TextDatumGetCString must be of type Datum, so use the
  more appropriate macro PG_GETARG_DATUM instead of PG_GETARG_TEXT_P.
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #256 (2680eee) into master (7a24403) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files          30       30           
  Lines        7028     7028           
=======================================
  Hits         6480     6480           
  Misses        548      548           
Impacted Files Coverage Δ
src/pl_funcs.c 95.15% <100.00%> (ø)
src/pl_hash_funcs.c 97.61% <100.00%> (ø)
src/pl_range_funcs.c 96.48% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kovdb75 kovdb75 merged commit 4e8efb7 into master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants