[#247] PortManager__Generic uses lock-dirs for reserved ports #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [FIX] A creation of self._log_dir is moved to reserve_port method - Code normalization [copy&paste mistakes] - New asserts are added - New comments are added
PortManager__Generic is updated.
|
Patch was tested with probackup2. |
This idea was taken from PgBouncer tests.
1) PortManager__Generic uses OsOperations::create_lock_fs_obj to create a lock object 2) utils.bound_ports is removed - TestTestgresLocal.test_ports_management is deleted - TestOsOpsCommon.test_create_lock_fs_obj is added
demonolock
approved these changes
Jun 23, 2025
|
У меня сомнения насчет это патча. Штука полезная, но слишком требовательная к устойчивости тестов - если блокировочные каталоги не удалять, то их потом надо будет чистить руками. Это не критично для одноразовых тестовых машин, но все равно как-то не очень... Пусть пока повисит. Можно по умолчанию оставить все как есть, а эту фичу оформить как новый класс. |
- _C_MIN_PORT_NUMBER - _C_MAX_PORT_NUMBER
|
Какой новый класс, делали чтобы проблему устранить же. И если и с проблемой живется ок, то может просто не делать вовсе |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New structures
Critical changes
Closes #247