Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5429~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5429
Choose a head ref
  • 6 commits
  • 135 files changed
  • 2 contributors

Commits on Mar 10, 2025

  1. Use PRI?64 instead of "ll?" in format strings (continued). 

    Continuation of work started in commit 15a79c7, after initial trial.

Discussion: https://postgr.es/m/b936d2fb-590d-49c3-a615-92c3a88c6c19%40eisentraut.org
    @macdice
    macdice authored and Commitfest Bot committed Mar 10, 2025
    Configuration menu
    Copy the full SHA
    e003384 View commit details
    Browse the repository at this point in the history

  2. pgbench: Make set_random_seed() 64-bit everywhere. 

    Delete an intermediate variable, a redundant cast, a use of long and a
use of long long.  scanf() the seed directly into a uint64, now that we
can do that with SCNu64 from <inttypes.h>.

The previous coding was from pre-C99 times when %lld might not have been
there, so it read into an unsigned long.  Therefore behavior varied
by OS, and --random-seed would accept either 32 or 64 bit seeds.  Now
it's the same everywhere.
    @macdice
    macdice authored and Commitfest Bot committed Mar 10, 2025
    Configuration menu
    Copy the full SHA
    80ad850 View commit details
    Browse the repository at this point in the history

  3. pgbench: Rationalize types in parseScriptWeight(). 

    This function wants to parse a 64 bit number, but complain if it's out
of range for int, and include the number in the error message.  OK, but
long is not always bigger than int, so it won't work the same on all
systems (and the cast to long long in the error message won't really
make it longer).

Parse an int64 with strtoi64(), and print it out with PRId64, so now it
will behave the same everywhere.
    @macdice
    macdice authored and Commitfest Bot committed Mar 10, 2025
    Configuration menu
    Copy the full SHA
    cce5387 View commit details
    Browse the repository at this point in the history

  4. pgbench: Modernize integer parsing routine. 

    strtoint64() is from pre-C99 times and had comments about scanf() not
being sure to handle long long.   Even though C99 scanf() can do SCNi64,
it seems like we'd lose a bit of error reporting.  A more obvious modern
drop-in is strtoi64().  Then strtoint64() can log the same errors as
before.
    @macdice
    macdice authored and Commitfest Bot committed Mar 10, 2025
    Configuration menu
    Copy the full SHA
    926987b View commit details
    Browse the repository at this point in the history

  5. Remove historical slashes from LSN format. 

    Ancient versions had a two-part XLogRecPtr where the parts had a
semantic meaning, and that was reflected in the display format.  Now
it's just a 64 bit number, so lets display it that way and remove most
remaining conversions to and from two-part form.

Unfortunately we can't defined a macro like LSN_FORMAT if we want
messages to be translatable.  Open-code formatting using <inttypes.h>
macros that the localization software understands.

XXX pg_upgrade probably needs to understand old format LSNs
    @macdice
    macdice authored and Commitfest Bot committed Mar 10, 2025
    Configuration menu
    Copy the full SHA
    d030270 View commit details
    Browse the repository at this point in the history

  6. [CF 5429] v2 - Adopt <inttypes.h> macros in format strings. 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5429

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CA+hUKGLDnhaYB6aCXr3z=K6sU85S9OR7d2bUXZWpy_=yJebUyg@mail.gmail.com
Author(s): Thomas Munro
    Commitfest Bot committed Mar 10, 2025
    Configuration menu
    Copy the full SHA
    5f7eef4 View commit details
    Browse the repository at this point in the history
Loading