Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5758~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5758
Choose a head ref
  • 4 commits
  • 2 files changed
  • 2 contributors

Commits on Jul 13, 2025

  1. doc: Fix confusing description of streaming option in START_REPLICATION. 

    Previously, the documentation described the streaming option as a boolean,
which is outdated since it's no longer a boolean as of protocol version 4.
This could confuse users.

This commit updates the description to remove the "boolean" reference and
clearly list the valid values for the streaming option.

Back-patch to v16, where the streaming option changed to a non-boolean.

Author: Euler Taveira <[email protected]>
Reviewed-by: Fujii Masao <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 16
    @MasaoFujii
    MasaoFujii authored and Commitfest Bot committed Jul 13, 2025
    Configuration menu
    Copy the full SHA
    6cea32b View commit details
    Browse the repository at this point in the history

  2. doc: Document default values for pgoutput options in protocol.sgml. 

    The pgoutput plugin options are described in the logical streaming
replication protocol documentation, but their default values were
previously not mentioned. This made it less convenient for users,
for example, when specifying those options to use pg_recvlogical
with pgoutput plugin.

This commit adds the explanations of the default values for pgoutput
options to improve clarity and usability.

Author: Fujii Masao <[email protected]>
Reviewed-by: Euler Taveira <[email protected]>
Discussion: https://postgr.es/m/[email protected]
    @MasaoFujii
    MasaoFujii authored and Commitfest Bot committed Jul 13, 2025
    Configuration menu
    Copy the full SHA
    c40d0c4 View commit details
    Browse the repository at this point in the history

  3. pgoutput: Initialize missing default for "origin" parameter. 

    The pgoutput plugin initializes optional parameters like "binary" with
default values at the start of processing. However, the "origin"
parameter was previously missed and left without explicit initialization.

Although the PGOutputData struct, which holds these settings,
is zero-initialized at allocation (resulting in publish_no_origin field
for "origin" parameter being false by default), this default was not
set explicitly, unlike other parameters.

This commit adds explicit initialization of the "origin" parameter to
ensure consistency and clarity in how defaults are handled.

Back-patch to v16, where "origin" parameter was added into pgoutput.

Author: Fujii Masao <[email protected]>
Reviewed-by: Euler Taveira <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 16
    @MasaoFujii
    MasaoFujii authored and Commitfest Bot committed Jul 13, 2025
    Configuration menu
    Copy the full SHA
    817cb78 View commit details
    Browse the repository at this point in the history

  4. [CF 5758] v2 - Document default values for pgoutput options 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5758

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): Fujii Masao
    Commitfest Bot committed Jul 13, 2025
    Configuration menu
    Copy the full SHA
    980803e View commit details
    Browse the repository at this point in the history
Loading