Skip to content

Unable to add new file from top navigation #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frankwinter opened this issue Oct 7, 2019 · 8 comments
Closed

Unable to add new file from top navigation #1180

frankwinter opened this issue Oct 7, 2019 · 8 comments

Comments

@frankwinter
Copy link
Contributor

  • Found a bug

It's not possible to Add File for a sketch. The console logs:
app.75f9d4564e8bb797e7c7.js:14 Uncaught TypeError: Cannot read property 'children' of undefined

Tested on MacOS Chrome & Safari

@catarak
Copy link
Member

catarak commented Oct 7, 2019

thanks for reporting! i'm currently not able to reproduce. can you be more specific about your steps to produce this bug? are you adding a text file or uploading a file? are you adding a file to the root directory of the sketch or to a subfolder? can you try this with a new sketch, because maybe it's something specific to how the sketch your testing on is configured?

@frankwinter
Copy link
Contributor Author

I just start the web editor and use the top menu to select SKETCH / ADD FILE - enter a name and hit ADD FILE. This leads to the error.
Using the sidebar to add a file works fine.

@socalledsound
Copy link

My class and I are also unable to load add any files to our sketches. It was working in the middle of last week but starting perhaps sunday? we can't add external files of any type. Have tried text and sound files. The editor responds as always but fails to load anything. Older sketches with image or sound assets are all still working fine.

@socalledsound
Copy link

and ps, how do you add a file using the sidebar?

@frankwinter
Copy link
Contributor Author

When you expand the sidebar to see all files you can click on the small triangle after "Sketch Files".

@frankwinter
Copy link
Contributor Author

Over here it looks like this:

Bildschirmfoto 2019-10-07 um 22 11 01

(Up to date Chrome, Safari and Firefox on MacOs)

@catarak catarak changed the title Unable to add new file Unable to add new file from top navigation Oct 7, 2019
@catarak
Copy link
Member

catarak commented Oct 7, 2019

@socalledsound that's a different error, but thanks for reporting! i think a PR i made caused that regression, i'll unmerge it and fix that issue.

@catarak catarak closed this as completed in 53241c9 Oct 8, 2019
catarak added a commit that referenced this issue Oct 8, 2019
@catarak
Copy link
Member

catarak commented Oct 8, 2019

just pushed a fix that should fix both of these issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants