Skip to content

Theme Colors + Accessibility #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
catarak opened this issue Feb 13, 2020 · 3 comments · Fixed by #1342, #1399 or #1406
Closed

Theme Colors + Accessibility #1263

catarak opened this issue Feb 13, 2020 · 3 comments · Fixed by #1342, #1399 or #1406
Labels
Area: Design For UI/UX design updates, proposals, or feedback Good First Issue A beginner-friendly issue, great for first-time contributors Priority:High Should be addressed soon but not critical Type:Task Tasks tied specifically to developer operations and maintenance

Comments

@catarak
Copy link
Member

catarak commented Feb 13, 2020

Nature of issue?

  • Existing feature enhancement

Feature enhancement details:

There are many open issues about Accessibility and Contrast (see the Accessibility Column). Rather than address all of these individually, I think it makes sense to start by looking at the design system and adjust the colors that haven't been updated. Maybe the light and dark themes should be WCAG AA, and the high contrast theme should be WCAG AAA?

To make changes to these colors, one needs to make changes to the theme variables, which will update throughout the whole app.

To make changes to the syntax highlighting colors, one needs to change:

This issue does not need to be completed in one big PR, rather, it can be done incrementally.

@catarak catarak added Good First Issue A beginner-friendly issue, great for first-time contributors Area: Design For UI/UX design updates, proposals, or feedback Priority:High Should be addressed soon but not critical Type:Task Tasks tied specifically to developer operations and maintenance labels Feb 13, 2020
@meganindya
Copy link

@catarak Can I work on this? I'd want to begin with the light theme.

@catarak
Copy link
Member Author

catarak commented Apr 1, 2020

In looking at #1342, I think there are also some CSS specificity issues!

@elit-altum
Copy link
Contributor

elit-altum commented Apr 4, 2020

@catarak Can I work on the high contrast theme ? Following WCAG AAA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design For UI/UX design updates, proposals, or feedback Good First Issue A beginner-friendly issue, great for first-time contributors Priority:High Should be addressed soon but not critical Type:Task Tasks tied specifically to developer operations and maintenance
Projects
None yet
3 participants