Skip to content

Increase font size button can concatenate 20 => 202 instead of adding #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lindapaiste opened this issue Aug 7, 2022 · 2 comments
Closed

Increase font size button can concatenate 20 => 202 instead of adding #2053

lindapaiste opened this issue Aug 7, 2022 · 2 comments
Labels
Bug Error or unexpected behaviors

Comments

@lindapaiste
Copy link
Collaborator

The "Increase" and "Decrease" font size buttons can have strange behavior if they are clicked after typing in the input.

To reproduce, click on the input and type 20. Then, without hitting Enter, click the "Increase" button. You should see this:
image

If the user hits Enter to submit the form then the "Increase" and "Decrease" buttons will work as expected.
@lindapaiste lindapaiste added the Bug Error or unexpected behaviors label Aug 7, 2022
@lindapaiste lindapaiste mentioned this issue Aug 8, 2022
Closed
4 tasks
@parteekcoder parteekcoder mentioned this issue Feb 24, 2023
Merged
@parteekcoder
Copy link
Contributor

@raclim this issue is solved you can review my PR #2129

@parteekcoder
Copy link
Contributor

@catarak @raclim please review my PR, your suggestions will be appreciated

@raclim raclim closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Error or unexpected behaviors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix prop-drilling in IDEView lindapaiste/p5.js-web-editor
3 participants
@lindapaiste @raclim @parteekcoder