Merge Collections to Master #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests mock the mogoose User model and the express Response model which isn't good. We should find a solution that makes use of the actual model object.
This ensures it's not accidentally exposed to the client when returning the key metadata
This is until this page's components are made theme-aware
There's duplication in the user and session endpoints that all return the same shaped user model data. The new helper should keep them consistent when new properties need to be exposed.
* Run tests on CI * Create a lint error on purpose * Splits build into test and deploy stages lint and test jobs will run in parallel and if both are successful (and branch is master), deploy will run. * Revert "Create a lint error on purpose" This reverts commit 306c91c. * Updating snapshot * Run deploy only on master branch (not PRs) * Use global deploy config item to avoid building on PRs
…update default p5.js version to latest (#1084)
…n add/remove sketch/collection
…ser model, return totalSize from user api request
… asset-limit-with-lambda
Feature/public api asset limit, Fixes #168
|
🎉 |
|
here goes nothing :) I can always undo it if there are any issues! |
This was referenced Mar 30, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified that this pull request:
npm run lint)Fixes #123I thin this is finally ready?? I think for now I may keep the API features off until we have more testing... but collections are set!