Skip to content

fix(high-contrast-theme): fixed failing WCAG AAA checks #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2020
Merged

fix(high-contrast-theme): fixed failing WCAG AAA checks #1380

merged 1 commit into from
Apr 10, 2020

Conversation

elit-altum
Copy link
Contributor

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

Continues on #1263

  • Fixes the failing WCAG AAA checks on the high-contrast theme on both visual and hidden elements

Screenshots
Visible-2

Hidden-2

@elit-altum
Copy link
Contributor Author

Sorry for the previous issue @catarak
I have tested with the sample code as well.

Please review!
Thank You!

@catarak
Copy link
Member

catarak commented Apr 10, 2020

thank you! looks great ✨

@catarak catarak merged commit 4cb4839 into processing:master Apr 10, 2020
@elit-altum elit-altum mentioned this pull request Apr 20, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elit-altum @catarak