fix(light-theme): fixed failing WCAG AA checks - I1263 #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@catarak Please review! |
e87df12 to
6461dff
Compare
6461dff to
db0dc43
Compare
|
i ended up building on top of this for a huge colors overhaul. thanks for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified that this pull request:
npm run lint)Fixes #123Fixes #1263
Changes
Fixed the failing WCAG AA checks for the light theme:
Also added the required scss tags of span etc. as seen in #1380
Flags
@catarak Can you please help me fix the 'Clear' button's failing check (marked in the above screenshot). It is currently using the 'inactive-text' variable's value. If I change the variable value to a more contrasting color, even the line numbers, project folders become more contrasting and begin competing for visual attention wrt the code lines.
Please help me find a solution. I think directly manipulating the button's color can provide a fix.
Thank You!
Covers #1277