Skip to content

font size fix #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 14, 2023
Merged

font size fix #2129

merged 5 commits into from
Mar 14, 2023

Conversation

parteekcoder
Copy link
Contributor

issue #2053

@raclim this issue is solved you can check my PR

Thanks , any suggestion from you will be admired

@parteekcoder
Copy link
Contributor Author

@raclim @catarak plz review this PR , your suggestions are admired by me

@parteekcoder
Copy link
Contributor Author

@raclim @davepagurek I tested this it runs fine , i think it can be merged

If you have any suggestions I will appreciate that

@davepagurek
Copy link
Contributor

Thanks @parteekcoder, this fix does look like it will effectively convert the input value to a number before incrementing! I'm not super familiar with the p5 editor source, so I'll still defer to @raclim for a final say here, in case e.g. there's a better place for this conversion.

@parteekcoder
Copy link
Contributor Author

Thanks @parteekcoder, this fix does look like it will effectively convert the input value to a number before incrementing!

Yes you are right , as before it is doing string concatenation that's why the issue occurred but now I improved to first convert input to number

@raclim
Copy link
Collaborator

raclim commented Mar 14, 2023

Looks good to me, thanks @parteekcoder and @davepagurek!

@raclim raclim merged commit 8c1b869 into processing:develop Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants