Skip to content

Remove accessibility CSS; Auto focus #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Mar 1, 2018
Merged

Conversation

MathuraMG
Copy link
Collaborator

@MathuraMG MathuraMG commented Mar 1, 2018

This PR addresses #566 and #504

We also noticed that there is a function in the reducer that can be completely removed - startAccessibleSketch . We were thinking of creating a new issue for this and clearing it out across the board. Does that sound good?

@lm-n
@CleezyITP

Before your pull request is reviewed and merged, make sure you

  • there are no linting errors -- npm run lint
  • code is in uniquely-named feature branch, and has been rebased on top of latest master. If you're asked to make more changes make sure you rebase onto master then too!
  • pull request is descriptively named and links to an issue number, i.e. Fixes #123

Thank you!

MathuraMG and others added 27 commits January 12, 2017 20:40
Transition from Interceptor to Accessibility Library
* Remove gitmodule (processing#509)


* remove git modules

* removed submodule and replaced interceptor for library

* removed submodule and replaced interceptor for library (processing#510)

* deleted comments

* deleted jquery

* deleted interceptor folder

* delete interceptor

* added jquery

* removed jquery and updated accessible library cdn

* Fixes processing#508 (processing#539)

* removed submodule and replaced interceptor for library

* deleted comments

* deleted jquery

* deleted interceptor folder

* delete interceptor

* added jquery

* removed jquery and updated accessible library cdn

* remove empty divs from files.js

* fix merge error

* remove empty divs from files.js

* Fixes processing#508  (processing#545)

* removed submodule and replaced interceptor for library

* deleted comments

* deleted jquery

* deleted interceptor folder

* delete interceptor

* added jquery

* removed jquery and updated accessible library cdn

* remove empty divs from files.js

* fix merge error

* remove empty divs from files.js

* moved accessible output css

* removed css, added aria-label, preliminary cdn update

* removed section from iframe

* updated cdn
@catarak
Copy link
Member

catarak commented Mar 1, 2018

yes, go ahead and make that issue!

@catarak catarak merged commit 3acefe4 into processing:master Mar 1, 2018
@lm-n lm-n mentioned this pull request Mar 2, 2018
3 tasks
@lm-n
Copy link
Member

lm-n commented Mar 2, 2018

created issue #585

@MathuraMG MathuraMG deleted the auto-focus branch March 6, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants