Skip to content

[ WIP ] Added new implementation of loop-protect (#698) #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

siddhant1
Copy link
Contributor

I have verified that this pull request:

  • [x ] has no linting errors (npm run lint)
  • [x ] is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • [ x] is descriptively named and links to an issue number, i.e. Fixes #123

@siddhant1
Copy link
Contributor Author

This code is successfully catching for(var) , while and do while infinite loops but stucks on for(let) loop. I have raised an issue , @catarak any possible implementation that you can think of rn?

@siddhant1
Copy link
Contributor Author

@catarak , I got a lead for his one , codesandbox is implementing loop-protection , I will have a look at their code and make progress with this one.
Meanwhile , have you got any leads , I might need some help with this one

@@ -0,0 +1,101 @@
const generateBefore = (t, id) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did you pull this file from?

@catarak
Copy link
Member

catarak commented May 2, 2019

just took a look at this... you are definitely on the right track! are you pulling in loop-protect from npm or github? it seems like you are not, and i think that's the right approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants